Make 4.x the main development #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- The main property is going to be replaced by mainClass in the JavaExec class. - Dynamically attempt to continue calling the original property, but upon failure call the new property instead.
…ty if available, else revert to the old property - This avoids any overhead in catching an exception if we're still running an older Gradle version.
- Upgraded Grolifant libray and adjusted use of ProjectOperations to avoid messages about configuration cache. Also updated package names where there were breaking changes. - Updated NPM modules for exporting slides. - Changed many 'compile' configurations to 'implementation' or 'api'. Some are still there and needs fixing.
So SkipWhenEmpty keeps working as now with Gradle 8.0. See https://docs.gradle.org/current/userguide/upgrading_version_7.html#empty_directories_file_tree.
Support removal of main property in Gradle 8.0
Support latest worker API for Gradle 8.0 compatibility
Add `@IgnoreEmptyDirectories` where adequate
Enable EPUB compatibility tests
Asciidoctor task is relocatable when `gemPaths` is configured
This prepares 4.0.0 final release. It fully integrates with Grolifant 2.2 and adopts the newer JVM execution models too, whichs allows for better integration with Gradle workers. This has been so successful that the default execution model is no a worker with classpath isolation as previously it always has been javaexec. JRuby: jruby-gradle plugin has been replaced with jruby-simple-plugin. This eliminates a number of issues with the previous plugin in terms of functionality and compatibiliy. It also restores plugin compatibility with JDK8 whereas the older plugin requires JDK11. GEMs: The issues with load errors for external GEMs has been resolved, but eliminating the use of GEM_PATH and rather compiling a custom GEM Jar on the fly and placing it on the classpath. Disabled plugins: Some plugins were disabled for this release and will probably be fixed for future releases. Due to their limited usage, it was thought better to get a release out now and fix these later. The plugins are: - Leanpub - Slides - Slides export Other: - `asciidoctorEditorConfig` is now lazy-created - Update to NodeJs plugin 2.0.1 - Remove most deprecated Grolifant 2.0 APIs Known issues: - Supplying an extension via a configuration rather than via `docExtensions` does not work. - GEM resolver test on Windows is failing. - Asciidotor.convertFile. Curretnly the Asciidoctor API does not allow for inspection of the Option object and the old Map methods are all deprecated. Closes: #628, #626, #655, #658, #664, #671, #673, #684, i#692, #693
Remove most deprecated Grolifant 2.0 APIs
This was referenced Jan 4, 2024
Closed
Update asciidoctor-diagram.adoc
|
As far as I can tell LGTM. Local build failed but this PR ran successfully on GH |
aalmiray
approved these changes
Jan 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will eventually be merged to master when 4.0.0 final is released.