-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Gradle Plugin docs #66
Add Gradle Plugin docs #66
Conversation
I don't understand the error. It seems to be looking for a path that does actually not exist.
|
2bfdc7e
to
a7912a1
Compare
Found an invalid referente, fixing 👍 |
cc30c17
to
f92771f
Compare
Are we ready to proceed with this PR, or is it still in draft? |
I'd need to review the status sorry, I recall the branch structure was not the same as for asciidoctorj/maven and I found some problem. |
No worries. I just wanted to make sure you weren't waiting on me. I'll be ready when you are ;) |
I need to re-think this. |
f92771f
to
eae9f76
Compare
Running to get preview, when all is fine I'll open PR pointing to the branch in the official gradle repo, not my fork. |
If it builds clean and the docs show up, I think that's sufficient, at least to start. We can always make adjustments after it goes live. |
643b6de
to
64aeb27
Compare
Thanks! Found an issue with a branch name thanks to the validations. Ready to merge. |
64aeb27
to
4978dce
Compare
This is a great start! Tremendous work. I'm so glad to see these docs finally come home. I'd like to request a few small changes before we merging.
Does that sound reasonable? |
Sure thing! When migrating I am so focused on the technical details (attributes, includes, refs, etc.) that I lose sight of keeping cohesion and user experience. PR ready: asciidoctor/asciidoctor-gradle-plugin#723. Any last thing? |
Should we put asciidoctoreditorconfig-plugin.adoc under plugins too? Aside from that, I think we can call it done for the first go live. |
Moving editorconfig makes a lot of sense. Changes applied and merged, let's release then 🚀 |
Looks great! Super work! Let's go! 🚀 |
This is for preview from the forked branch linked to PR asciidoctor/asciidoctor-gradle-plugin#601Updated to new PR asciidoctor/asciidoctor-gradle-plugin#722