Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]: add missing tests for nested service provider #1

Merged
merged 2 commits into from
Sep 21, 2023

Conversation

asciito
Copy link
Owner

@asciito asciito commented Sep 21, 2023

This PR add the missing tests to test the nesting or location of more than one service provider in the package.

Also this PR include(s):

  1. Rename property of migrations and config traits.
    • This fix prevent the collision/shadowing of a protected property between both traits

Signed-off-by: Ayax Córdova <ayax.cordova@aydev.mx>
I add the missing tests to test the location of different ServiceProviders loading its own configuration.

Signed-off-by: Ayax Córdova <ayax.cordova@aydev.mx>
@asciito asciito self-assigned this Sep 21, 2023
@asciito asciito marked this pull request as ready for review September 21, 2023 02:13
@asciito asciito merged commit b63f940 into develop Sep 21, 2023
7 checks passed
@asciito asciito deleted the fix/add-missing-tests-for-nested-service-provider branch September 21, 2023 02:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant