harvester: add arXiv metadata harvester #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChiaraBi
force-pushed
the
arxiv_harvester
branch
5 times, most recently
from
3ca54b5
to
1548182
Compare
ChiaraBi
force-pushed
the
arxiv_harvester
branch
from
1548182
to
8494608
Compare
Pull Request Test Coverage Report for Build 240
💛 - Coveralls |
Glignos
reviewed
Jul 19, 2019
| else: | ||
| return False | ||
|
|
||
| def get_metadata(self, arxiv_id): |
There was a problem hiding this comment.
Using the same function name in this case (for Client and Harvester might be a bit misleading)
| # Identifiers | ||
| result['Identifier'] = [] | ||
| doi = metadata['doi'] | ||
| if doi: |
There was a problem hiding this comment.
As a suggestion maybe the construction of the results could be a separate function to make it more distinct.
|
|
||
| def get_metadata(self, arxiv_id): | ||
| """Get metadata from ArXiv.""" | ||
| res = arxiv.query(query="", |
There was a problem hiding this comment.
I am not sure if this is in the scope, but maybe we could make this function a bit more versatile by providing a by default empty query, giving us the chance in the future to harvest by query too if needed without having to refactor this.
| """.""" | ||
| data = self.get_metadata(identifier) | ||
| if data: | ||
| providers = set(providers) if providers else set() |
There was a problem hiding this comment.
Is there a case where we can get duplicate providers?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.