Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(airtable): handle more types correctly #69

Merged
merged 2 commits into from
Nov 17, 2024
Merged

fix(airtable): handle more types correctly #69

merged 2 commits into from
Nov 17, 2024

Conversation

ascorbic
Copy link
Owner

Fixes #47

Copy link

changeset-bot bot commented Nov 17, 2024

🦋 Changeset detected

Latest commit: 8942053

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@ascorbic/airtable-loader Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@ascorbic ascorbic requested a review from Copilot November 17, 2024 10:22
Copy link

netlify bot commented Nov 17, 2024

Deploy Preview for astro-loaders ready!

Name Link
🔨 Latest commit 8942053
🔍 Latest deploy log https://app.netlify.com/sites/astro-loaders/deploys/6739c75aacb7f500084e3db1
😎 Deploy Preview https://deploy-preview-69--astro-loaders.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 8 changed files in this pull request and generated no suggestions.

Files not reviewed (3)
  • packages/airtable/package.json: Language not supported
  • packages/airtable/test/hello.test.ts: Evaluated as low risk
  • packages/airtable/src/airtable-loader.ts: Evaluated as low risk
Comments skipped due to low confidence (1)

packages/airtable/src/schema.ts:115

  • The use of 'console.log' might not be intended for production code. Consider removing it or using a proper logging mechanism.
console.log("formula result type:", resultType);
@ascorbic ascorbic enabled auto-merge (squash) November 17, 2024 10:37
@ascorbic ascorbic merged commit 3df2c6e into main Nov 17, 2024
6 checks passed
@ascorbic ascorbic deleted the airtable-parse branch November 17, 2024 10:38
@mixie-bot mixie-bot bot mentioned this pull request Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@ascorbic/airtable-loader: multipleLookupValues and formula aren't always string type
1 participant