Add convenience methods for fetching nodes deep in the tree #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Files
|
robyww
reviewed
Feb 9, 2026
robyww
left a comment
robyww
left a comment
There was a problem hiding this comment.
This looks good. I think it will make the library easier to use. thanks!.
|
|
||
| final AsdfNode currentKey = constructKeyNode(keys[0]); | ||
|
|
||
| return get(currentKey).get(Arrays.copyOfRange(keys, 1, keys.length)); |
There was a problem hiding this comment.
I can see a reason to copy the array for this operation. If upoi were going to modify it or it was threaded it might make sense but it does not appear necessary here.
I see this in other places as well.
Contributor
Author
There was a problem hiding this comment.
I need to pass the array without its first element, is there a better way to do that? I could add an additional get(...) overload that accepts the array start index.
alphasentaurii
approved these changes
Feb 9, 2026
alphasentaurii
left a comment
alphasentaurii
left a comment
There was a problem hiding this comment.
This looks good - appreciate the added test case for this as well. Thanks Ed!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds convenience methods for fetching nodes deep in the tree. For example, until now it has been necessary to chain method calls to get to a node at path
root.child.grandchild:This PR adds vararg overloads of the get methods so that this can be accomplished in a single method call:
Since varargs can't be followed by other arguments, I'm also deprecating the old getList and getMap methods and introducing new methods that place the list and map types at the beginning of the argument list.
Thanks Trey for the idea!