Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove non-working reference file tests #1824

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

braingram
Copy link
Contributor

@braingram braingram commented Aug 12, 2024

Description

The tests in asdf._tests.test_reference_files.py have not been running since Feb 2022 (#1079) since they looked for asdf-standard as it existed when it was a submodule:

_REFFILE_PATH = os.path.join(os.path.dirname(__file__), "..", "..", "asdf-standard", "reference_files")

This PR removes the tests and asdf-format/asdf-standard#440 adds them to asdf-standard (where the reference files are available).

Fixes: #1522

Checklist:

  • pre-commit checks ran successfully
  • tests ran successfully
  • for a public change, a changelog entry was added
  • for a public change, documentation was updated
  • for any new features, unit tests were added

@braingram braingram marked this pull request as ready for review August 12, 2024 20:46
@braingram braingram requested a review from a team as a code owner August 12, 2024 20:46
Copy link
Member

@zacharyburnett zacharyburnett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was just looking at these tests yesterday and wondering how they worked

@braingram braingram force-pushed the remove_reference_file_tests branch from 077c54b to ca2d836 Compare August 14, 2024 13:15
@braingram braingram enabled auto-merge August 14, 2024 13:15
@braingram braingram merged commit dbbc26f into asdf-format:main Aug 14, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

asdf-standard submodule no longer checked out in CI
2 participants