Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pyproject.toml: version_file requires setuptools_scm>=8 #1894

Merged
merged 1 commit into from
Jan 12, 2025

Conversation

wdconinc
Copy link
Contributor

Description

When the switch was made from write_to to version_file, the version requirement on setuptools_scm was not increased. version_file is only available as of v8, https://github.com/pypa/setuptools-scm/blob/v8.0.4/CHANGELOG.md?plain=1#L62.

Tasks

Most tasks below are not applicable.

  • run pre-commit on your machine
  • run pytest on your machine
  • Does this PR add new features and / or change user-facing code / API? (if not, label with no-changelog-entry-needed)
    • write news fragment(s) in changes/: echo "changed something" > changes/<PR#>.<changetype>.rst (see below for change types)
    • update relevant docstrings and / or docs/ page
    • for any new features, add unit tests

Copy link
Contributor

@braingram braingram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for finding the mistake!

@braingram braingram merged commit 43e1947 into asdf-format:main Jan 12, 2025
33 of 34 checks passed
@wdconinc wdconinc deleted the patch-1 branch January 12, 2025 21:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants