Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update azure-cli python dependency #844

Merged
merged 3 commits into from
Jul 1, 2023
Merged

fix: Update azure-cli python dependency #844

merged 3 commits into from
Jul 1, 2023

Conversation

fragolinux
Copy link
Contributor

forced and fixed python version 3.10.11

Summary

Description:

Checklist

  • Format with scripts/format.bash
  • Test locally with scripts/test_plugin.bash --file plugins/<your_new_plugin_name>
  • Your plugin CI tests are green
    • Tip: use the plugin_test action from asdf-actions in your plugin CI

@fragolinux fragolinux requested a review from a team as a code owner June 23, 2023 11:07
@fragolinux fragolinux changed the title Update azure-cli fix: Update azure-cli python dependency Jun 23, 2023
forced and fixed python version 3.10.11
@jthegedus
Copy link
Contributor

Changing plugins from one repo to another is something we want to avoid if at all possible.

It would be great if you could link an open issue on the original repo showing that this change has tried to be added upstream and ignored after some time, that it is blocking a large number of users, or that the maintainer is inactive or unresponsive.

Also, changes would need to be made for this entry in the README file.

Thanks.

@fragolinux
Copy link
Contributor Author

fragolinux commented Jun 25, 2023

The original azure-cli asdf plugin repo is archived and not maintened, as the author does not use the tool anymore, since last November... Does not work AT ALL if using python 3.11, so we fixed a python version 3.10, using asdf itself, inside our fork...

It's an open issue on the upstream tool: Azure/azure-cli#24494

Reported in other issues, too, where the solution is what we did, downgrade python: Azure/azure-cli#24458

What do we need to do on readme? Just change the plugin repo, there, too?

Thanks!

P.S. Changing a repo is something that you did just a few days ago, on the JQ plugin 😉

@fragolinux
Copy link
Contributor Author

@jthegedus

hi fixed the readme, pointing to our repo, and for the other things you asked, I already replied above (and here where you did the same on the jq plugin, just a few days ago)

@jthegedus
Copy link
Contributor

P.S. Changing a repo is something that you did just a few days ago, on the JQ plugin 😉

Yes, and there was discussion in that thread from many people about the existing plugin and it's lack of support. This thread is just you raising it. The additional information you provided was what I was after, thanks.

@jthegedus jthegedus merged commit ebc3820 into asdf-vm:master Jul 1, 2023
3 checks passed
mbutov pushed a commit to mbutov/asdf-plugins that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants