Skip to content

fix: properly pass missing env vars in Plugin.Update #1899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix: properly pass missing env vars in Plugin.Update #1899

wants to merge 1 commit into from

Conversation

n-rodriguez
Copy link
Contributor

Summary

Properly pass missing env vars in Plugin.Update

Fixes:

Thank you!

@n-rodriguez n-rodriguez requested a review from a team as a code owner February 6, 2025 02:31
@n-rodriguez n-rodriguez mentioned this pull request Feb 6, 2025
Closed
@missingcharacter missingcharacter mentioned this pull request Feb 8, 2025
Open
Stratus3D
Stratus3D reviewed Feb 8, 2025
View reviewed changes
internal/plugins/plugins.go Outdated
@@ -255,6 +255,9 @@ func (p Plugin) Update(conf config.Config, ref string, out, errout io.Writer) (s
}

env := map[string]string{
"HOME": os.Getenv("HOME"),
"ASDF_DIR": os.Getenv("ASDF_DIR"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ASDF_DIR isn't something that is used in asdf 0.16.0+. Are there still plugins relying on this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there still plugins relying on this?

Yes : https://github.com/asdf-vm/asdf-nodejs/blob/93bd217ba74f05080eebb7d8e1c146a385b01d7f/lib/utils.sh#L24

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a reason why we shouldn't propagate all env variables of the current process by default here (similar to #1958 )?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @Stratus3D thank you!

Stratus3D
Stratus3D reviewed Feb 19, 2025
View reviewed changes
Copy link
Member

@Stratus3D Stratus3D left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think if plugin callbacks need arbitrary environment variables I think we should pass-through any environment variable that is already set. Like we do for shims when executing the real executable.

@andrecloutier andrecloutier mentioned this pull request Feb 23, 2025
Merged
@n-rodriguez
Copy link
Contributor Author

Closed in favor of #1982

@n-rodriguez n-rodriguez deleted the fix/missing_env_vars branch February 24, 2025 18:30
@Stratus3D
Copy link
Member

Replaced by #1982

@n-rodriguez
Copy link
Contributor Author

@Stratus3D Closed in favor of #1982

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrecloutier andrecloutier andrecloutier left review comments

@Stratus3D Stratus3D Stratus3D left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@n-rodriguez @Stratus3D @andrecloutier