fix(golang-rewrite): print error message when app.Run fails#2228
Open
teal-bauer wants to merge 1 commit intoasdf-vm:masterfrom
Open
fix(golang-rewrite): print error message when app.Run fails#2228teal-bauer wants to merge 1 commit intoasdf-vm:masterfrom
teal-bauer wants to merge 1 commit intoasdf-vm:masterfrom
Conversation
Author
|
I cannot count the number of times I have accidentally run |
Author
|
Ping @asdf-vm/core? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Previously, when
app.Run()returned an error (e.g.,asdf set -h foo 1.2.3), the CLI would exit with code 1 but print nothing, making it difficult to understand what went wrong.Now the error message is printed (e.g., "No help topic for 'foo'").
Test plan
asdf set -h foo 1.2.3now prints error messageasdf set -hstill shows help with exit code 0asdf set <tool> <version>still worksgo test ./internal/cli/...)