fix: Make plugin test resolve latest version#2246
Open
maciektr wants to merge 3 commits intoasdf-vm:masterfrom
Open
fix: Make plugin test resolve latest version#2246maciektr wants to merge 3 commits intoasdf-vm:masterfrom
maciektr wants to merge 3 commits intoasdf-vm:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
If
--asdf-tool-version=latestis passed toplugin test, it should resolve the version correctly, instead of passinglatestdirectly.This change mimics the one of the old bash plugin:
asdf/lib/commands/command-plugin-test.bash
Lines 129 to 138 in 31e8c93
It also adds a test case to ensure correct behaviour of the changed code.
Fixes: #2193
Other Information