Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4.0: Return a single record from Ash.read when the action has get?: true #1800

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

4.0: Return a single record from Ash.read when the action has get?: true #1800

wants to merge 1 commit into from

Conversation

JohnDoneth
Copy link

Closes #1628

Make get?: true read actions cause Ash.read to return a single record, just like pagination causes it to return a page.

Contributor checklist

  • Bug fixes include regression tests
  • Chores
  • Documentation changes
  • Features include unit/acceptance tests
  • Refactoring
  • Update dependencies

@zachdaniel
Copy link
Contributor

If we want to introduce this now, we have to gate it behind a compilation flag. Additionally this will almost certainly break other packages calling Ash.read. So I think we would be best suited waiting until 4.0 (that's why the 4.0 prefix in the issue name).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.0: Return a single record from Ash.read when the action has get?: true
2 participants
@JohnDoneth @zachdaniel