handle return_skipped_upsert? in bulk creates #2343
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new capability value for the can? callback in datalayers. If the data-layer doesn't support the option it falls back to regular upserts.
This was referenced Oct 2, 2025
zachdaniel
reviewed
Oct 2, 2025
lib/ash/actions/create/bulk.ex
Outdated
| not Ash.DataLayer.data_layer_can?(resource, :bulk_upsert_return_skipped) do | ||
| false | ||
| else | ||
| Ash.DataLayer.data_layer_can?(resource, :bulk_create) |
There was a problem hiding this comment.
lets check this first, and then check the other stuff.
barnabasJ
changed the title
zachdaniel
reviewed
Oct 3, 2025
|
Looks good but one question. |
|
Feel free to merge once resolved ❤️ |
I would but I can't ;) merging is blocked without 1 approval and I don't have the rights to skip that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist
Leave anything that you believe does not apply unchecked.
extra context