feat: probe function #17
Conversation
There was a problem hiding this comment.
Hey @Lukejkw thanks so much. Just a couple of minor changes to make and one major change. I've left comments in the code for you to look at.
Cheers
Ash
| const { fn, details } = loadUserFn(argv, `record => transform(record)`); | ||
|
|
||
| const data = await inputData(argv); | ||
| verifyInputArray(data, 'map'); |
There was a problem hiding this comment.
This should take the name of the command to display for the help, which is 'probe' instead of 'map'.
| const data = await inputData(argv); | ||
| verifyInputArray(data, 'map'); | ||
|
|
||
| data.map((record: any) => { |
There was a problem hiding this comment.
Can we change this to a forEach because it doesn't actually have to create a new array.
|
|
||
| data.map((record: any) => { | ||
| const result = invokeUserFn(() => fn(record), details); | ||
| console.log(result); |
There was a problem hiding this comment.
@Lukejkw I just realised this isn't going to work.
Because Datakit relies on being able to output clean JSON data to the stdout you can't get away with console logging anything like this.
You could change it to console.error. Would that work for you?
| data.map((record: any) => { | ||
| const result = invokeUserFn(() => fn(record), details); | ||
| console.log(result); | ||
| return record; |
There was a problem hiding this comment.
Once the map above is changed to forEach this return statement can be removed.
Opening PR for comment to see if this is something that would be useful and feedback.
A probe function is essentially like a bisection - allowing you to "probe" into some data to see what a value is without actually changing the output. It's usually useful for debugging purposes.