Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimised some images and fixed upside down school logo in education section #158

Merged
merged 5 commits into from
Oct 14, 2021
Merged

Conversation

dhruvkrishnavaid
Copy link
Contributor

Optimised some images (thanks to ImgBot), and fixed upside down school logo in education section.
This PR will close #139.

@ashutosh1919
Copy link
Owner

@dhruvkrishnavaid , I don't understand why did you delete images?

@dhruvkrishnavaid
Copy link
Contributor Author

The images aren't deleted. They are just compressed. This compression would decrease the loading time of the site.

@dhruvkrishnavaid
Copy link
Contributor Author

@NirmalSilwal Please tell if this commit works for #159.

Copy link

@NirmalSilwal NirmalSilwal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @dhruvkrishnavaid it didn't work for #159

I even tried changing that 100 to 300, tried both, but org lists is same as before. Any other solution on it please!
Attaching code snippet for reference

const query_org = {
  query: `query{
	user(login: "${openSource.githubUserName}") {
    repositoriesContributedTo(last: 300, contributionTypes: [COMMIT, ISSUE, PULL_REQUEST, REPOSITORY]){
	      totalCount
	      nodes{
	        owner{
	          login
	          avatarUrl
	          __typename
	        }
	      }
	    }
	  }
	}`,
};

@NirmalSilwal
Copy link

@dhruvkrishnavaid @ashutosh1919 should I write org lists manually in "./src/shared/opensource/organizations.json"?

@dhruvkrishnavaid
Copy link
Contributor Author

@dhruvkrishnavaid @ashutosh1919 should I write org lists manually in "./src/shared/opensource/organizations.json"?

Yes you definitely can. But that would be a temporary solution because the next time you run node git_data_fetcher.mjs, it will update the data you wrote with the data it fetches. I think, #159 should be kept open until a proper fix is applied.

@NirmalSilwal
Copy link

okay, let's see if someone can resolve it meanwhile

@ashutosh1919
Copy link
Owner

Hello @dhruvkrishnavaid it didn't work for #159

I even tried changing that 100 to 300, tried both, but org lists is same as before. Any other solution on it please! Attaching code snippet for reference

const query_org = {
  query: `query{
	user(login: "${openSource.githubUserName}") {
    repositoriesContributedTo(last: 300, contributionTypes: [COMMIT, ISSUE, PULL_REQUEST, REPOSITORY]){
	      totalCount
	      nodes{
	        owner{
	          login
	          avatarUrl
	          __typename
	        }
	      }
	    }
	  }
	}`,
};

@dhruvkrishnavaid , Do you want to fix this issue in this PR or do you want to create separate one for this? what do you think ? I suggest to create separate PR for this.

@dhruvkrishnavaid
Copy link
Contributor Author

Hello @dhruvkrishnavaid it didn't work for #159
I even tried changing that 100 to 300, tried both, but org lists is same as before. Any other solution on it please! Attaching code snippet for reference

const query_org = {
  query: `query{
	user(login: "${openSource.githubUserName}") {
    repositoriesContributedTo(last: 300, contributionTypes: [COMMIT, ISSUE, PULL_REQUEST, REPOSITORY]){
	      totalCount
	      nodes{
	        owner{
	          login
	          avatarUrl
	          __typename
	        }
	      }
	    }
	  }
	}`,
};

@dhruvkrishnavaid , Do you want to fix this issue in this PR or do you want to create separate one for this? what do you think ? I suggest to create separate PR for this.

I'll create a separate PR if I find the fix.

@ashutosh1919
Copy link
Owner

@dhruvkrishnavaid , cool. Can you remove this fix from this PR then?

allcontributors bot and others added 4 commits October 13, 2021 20:01
* docs: update README.md [skip ci]

* docs: update .all-contributorsrc [skip ci]

Co-authored-by: allcontributors[bot] <46447321+allcontributors[bot]@users.noreply.github.com>
*Total -- 10,928.16kb -> 10,332.34kb (5.45%)

/src/assests/images/deeplearning_ai_logo.png -- 94.59kb -> 36.44kb (61.47%)
/images/masterportfolio-banner-dark.png -- 40.97kb -> 23.40kb (42.87%)
/images/masterportfolio-banner-light.png -- 41.41kb -> 24.31kb (41.31%)
/public/logo192.png -- 8.38kb -> 5.10kb (39.13%)
/public/logo512.png -- 22.38kb -> 14.05kb (37.24%)
/src/assests/images/talksCardBack.svg -- 0.55kb -> 0.39kb (29.59%)
/src/assests/images/talksCardBackAlt.svg -- 0.67kb -> 0.50kb (24.38%)
/src/assests/images/github_logo.png -- 34.82kb -> 26.43kb (24.08%)
/src/assests/images/nptel_logo.png -- 47.05kb -> 36.42kb (22.6%)
/src/assests/images/stanford_logo.png -- 104.01kb -> 81.67kb (21.48%)
/src/assests/images/gcp_logo.png -- 42.47kb -> 33.76kb (20.5%)
/src/assests/images/dsc_logo.png -- 238.28kb -> 191.34kb (19.7%)
/src/assests/images/ibm_logo.png -- 109.62kb -> 88.91kb (18.89%)
/src/assests/images/coursera_logo.png -- 6.10kb -> 5.25kb (13.94%)
/src/assests/images/codeInLogo.png -- 93.34kb -> 82.25kb (11.88%)
/src/assests/images/legato_logo.png -- 31.35kb -> 27.69kb (11.69%)
/src/assests/images/animated_ashutosh.png -- 136.87kb -> 121.34kb (11.35%)
/src/assests/images/muffito_logo.png -- 47.22kb -> 41.89kb (11.28%)
/src/assests/images/freecopy_logo.png -- 3.07kb -> 2.74kb (10.96%)
/src/assests/images/mozilla_logo.png -- 1.89kb -> 1.71kb (9.72%)
/images/masterPortfolioThemes.png -- 234.33kb -> 213.47kb (8.9%)
/src/assests/images/contactMail.png -- 110.76kb -> 104.52kb (5.64%)
/src/assests/images/portfolio.gif -- 5,871.79kb -> 5,617.63kb (4.33%)
/src/assests/font-awesome/sprites/solid.svg -- 602.82kb -> 586.65kb (2.68%)
/src/assests/images/education.svg -- 6.37kb -> 6.21kb (2.57%)
/src/assests/font-awesome/sprites/regular.svg -- 106.88kb -> 104.13kb (2.57%)
/src/assests/images/animated_logo.svg -- 78.21kb -> 76.29kb (2.46%)
/src/assests/images/fullstack.svg -- 7.72kb -> 7.57kb (1.92%)
/src/assests/images/jsFramework.svg -- 20.27kb -> 19.89kb (1.87%)
/public/apple-icon-152x152.png -- 18.75kb -> 18.43kb (1.71%)
/src/assests/font-awesome/sprites/brands.svg -- 435.80kb -> 428.38kb (1.7%)
/public/apple-icon-120x120.png -- 13.07kb -> 12.85kb (1.67%)
/src/assests/images/nextuLogo.jpg -- 8.69kb -> 8.54kb (1.63%)
/public/ms-icon-150x150.png -- 18.42kb -> 18.12kb (1.62%)
/public/apple-icon-precomposed.png -- 27.06kb -> 26.63kb (1.59%)
/public/apple-icon.png -- 27.06kb -> 26.63kb (1.59%)
/public/apple-icon-144x144.png -- 17.26kb -> 16.99kb (1.58%)
/public/ms-icon-144x144.png -- 17.26kb -> 16.99kb (1.58%)
/public/android-icon-144x144.png -- 17.26kb -> 16.99kb (1.58%)
/public/apple-icon-180x180.png -- 24.33kb -> 23.95kb (1.57%)
/public/ms-icon-310x310.png -- 56.18kb -> 55.30kb (1.56%)
/src/assests/font-awesome/webfonts/fa-regular-400.svg -- 141.07kb -> 138.90kb (1.54%)
/public/apple-icon-114x114.png -- 12.12kb -> 11.94kb (1.47%)
/public/favicon-32x32.png -- 2.29kb -> 2.26kb (1.45%)
/public/ms-icon-70x70.png -- 5.97kb -> 5.89kb (1.42%)
/public/android-icon-36x36.png -- 2.62kb -> 2.58kb (1.42%)
/src/assests/font-awesome/webfonts/fa-solid-900.svg -- 822.86kb -> 811.20kb (1.42%)
/src/assests/images/blogs_image.svg -- 11.96kb -> 11.80kb (1.35%)
/src/assests/images/feelingProud.svg -- 12.15kb -> 11.99kb (1.34%)
/src/assests/images/pwa.png -- 19.54kb -> 19.28kb (1.33%)
/public/android-icon-48x48.png -- 3.68kb -> 3.63kb (1.3%)
/public/apple-icon-57x57.png -- 4.52kb -> 4.46kb (1.28%)
/public/apple-icon-60x60.png -- 4.80kb -> 4.74kb (1.24%)
/public/android-icon-96x96.png -- 9.38kb -> 9.27kb (1.19%)
/public/favicon-96x96.png -- 9.38kb -> 9.27kb (1.19%)
/src/assests/images/googleAssistant.svg -- 0.84kb -> 0.83kb (1.17%)
/public/apple-icon-76x76.png -- 6.68kb -> 6.62kb (1.04%)
/public/apple-icon-72x72.png -- 6.16kb -> 6.09kb (1.03%)
/public/android-icon-72x72.png -- 6.16kb -> 6.09kb (1.03%)
/public/android-icon-192x192.png -- 26.50kb -> 26.25kb (0.93%)
/src/assests/images/data_science.svg -- 10.00kb -> 9.91kb (0.9%)
/src/assests/images/iiitk_logo.png -- 63.29kb -> 62.77kb (0.83%)
/src/assests/font-awesome/webfonts/fa-brands-400.svg -- 684.08kb -> 678.60kb (0.8%)
/src/assests/font-awesome/svgs/solid/swatchbook.svg -- 0.44kb -> 0.44kb (0.66%)
/src/assests/images/developerActivity.svg -- 27.00kb -> 26.85kb (0.53%)
/src/assests/images/manOnTable.svg -- 44.85kb -> 44.73kb (0.27%)
/src/assests/images/address_image.svg -- 19.67kb -> 19.62kb (0.27%)
/src/assests/images/projects_image.svg -- 21.81kb -> 21.76kb (0.21%)
/src/assests/images/programmer.svg -- 20.41kb -> 20.38kb (0.15%)
/src/assests/images/experience.svg -- 19.06kb -> 19.03kb (0.15%)
/src/assests/images/ui_ux_design.svg -- 60.90kb -> 60.81kb (0.14%)
/src/assests/images/cloud_infrastructure.svg -- 11.90kb -> 11.89kb (0.11%)
/src/assests/font-awesome/svgs/solid/hand-holding-usd.svg -- 1.05kb -> 1.05kb (0.09%)
/src/assests/font-awesome/svgs/brands/laravel.svg -- 1.67kb -> 1.67kb (0.06%)
/src/logo.svg -- 8.01kb -> 8.01kb (0.01%)

Signed-off-by: ImgBotApp <ImgBotHelp@gmail.com>
@dhruvkrishnavaid
Copy link
Contributor Author

@dhruvkrishnavaid , cool. Can you remove this fix from this PR then?

Done

Copy link
Owner

@ashutosh1919 ashutosh1919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for contributing.

@ashutosh1919 ashutosh1919 merged commit 848d924 into ashutosh1919:master Oct 14, 2021
@ashutosh1919
Copy link
Owner

@all-contributors please add @dhruvkrishnavaid for idea

@allcontributors
Copy link
Contributor

@ashutosh1919

I've put up a pull request to add @dhruvkrishnavaid! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] School logo is upside down in the Education Section
4 participants