Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: multiple console errors #334

Merged

Conversation

varundhand
Copy link
Contributor

@varundhand varundhand commented Oct 24, 2023

Closes issue #333

Changes Made:

  • Fixed syntax errors
  • Resolved semantic issues
  • Corrected logical errors

Screenshots:

Before:

Screenshot 2023-10-25 at 2 03 18 AM

After( clear console without any errors ):

Screenshot 2023-10-25 at 2 47 18 AM

@varundhand
Copy link
Contributor Author

@ashutosh1919 ready for review :)

@ashutosh1919
Copy link
Owner

@varundhand please remove svg files from this commit! Those won't change to remove errors right?

@varundhand
Copy link
Contributor Author

Probably not. Let me remove them then.

@varundhand
Copy link
Contributor Author

@ashutosh1919 I have removed the svg files now, you can review it :)

Copy link
Owner

@ashutosh1919 ashutosh1919 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ashutosh1919 ashutosh1919 merged commit a97c79d into ashutosh1919:master Oct 29, 2023
10 checks passed
@ashutosh1919
Copy link
Owner

@allcontributors please add @varundhand for code

@allcontributors
Copy link
Contributor

@ashutosh1919

I've put up a pull request to add @varundhand! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants