Fix: Types in sparse dot-products generic macro #253
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re: types
The dot-product intrinsics _mm256_dpbf16_ps, _mm256_dpwssd_epi32, and svbfdot_f32 each widen the values before multiplying them, so the scalar algorithm should also do that. Also, the macro currently uses the
counter_type
, which is an unsigned int.Re: saturating addition
Same links, none of them perform saturating addition other than the currently used
_mm256_dpwssds_epi32
, so the currentspdot_counts_u16_turin
kernel is the odd one out.