Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: implement basic authentication at info refs #17

Merged
merged 2 commits into from
May 29, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ Flags

```
Usage of ./git-http-backend:
-require_auth bool
set require auth enable/disable
-auth_pass_env_var string
set an env var to provide the basic auth pass as
-auth_user_env_var string
Expand Down Expand Up @@ -97,4 +99,4 @@ IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY
CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT,
TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE
SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
```
```````
1 change: 1 addition & 0 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import (
)

func init() {
flag.BoolVar(&server.DefaultConfig.RequireAuth, "require_auth", server.DefaultConfig.RequireAuth, "enable basic auth")
flag.StringVar(&server.DefaultConfig.AuthPassEnvVar, "auth_pass_env_var", server.DefaultConfig.AuthPassEnvVar, "set an env var to provide the basic auth pass as")
flag.StringVar(&server.DefaultConfig.AuthUserEnvVar, "auth_user_env_var", server.DefaultConfig.AuthUserEnvVar, "set an env var to provide the basic auth user as")
flag.StringVar(&server.DefaultConfig.DefaultEnv, "default_env", server.DefaultConfig.DefaultEnv, "set the default env")
Expand Down
23 changes: 22 additions & 1 deletion server/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ type Service struct {
}

type Config struct {
RequireAuth bool
AuthPassEnvVar string
AuthUserEnvVar string
DefaultEnv string
Expand All @@ -46,6 +47,7 @@ var (
DefaultAddress = ":8080"

DefaultConfig = Config{
RequireAuth: false,
AuthPassEnvVar: "",
AuthUserEnvVar: "",
DefaultEnv: "",
Expand Down Expand Up @@ -211,7 +213,19 @@ func getInfoRefs(hr HandlerReq) {
service_name := getServiceType(r)
access := hasAccess(r, dir, service_name, false)
version := r.Header.Get("Git-Protocol")
if access {

user, password, authok := r.BasicAuth()
if DefaultConfig.RequireAuth && !authok {
renderAuthRequire(w)
return
}

if authok && user != DefaultConfig.AuthUserEnvVar && password != DefaultConfig.AuthPassEnvVar {
w.WriteHeader(http.StatusUnauthorized)
return
}

if access {
args := []string{service_name, "--stateless-rpc", "--advertise-refs", "."}
refs := gitCommand(dir, version, args...)

Expand Down Expand Up @@ -387,6 +401,13 @@ func renderNoAccess(w http.ResponseWriter) {
w.Write([]byte("Forbidden"))
}

func renderAuthRequire(w http.ResponseWriter) {
w.Header().Add("Content-Type", "text/plain")
w.Header().Add("WWW-Authenticate", "Basic realm=\"authorization needed\"")
w.WriteHeader(http.StatusUnauthorized)
w.Write([]byte("401 Unauthorized"))
}

// Packet-line handling function

func packetFlush() []byte {
Expand Down
Loading