Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a Villain Page #250

Closed
rajdeepchakraborty-rc opened this issue Oct 26, 2024 · 19 comments · Fixed by #367
Closed

Add a Villain Page #250

rajdeepchakraborty-rc opened this issue Oct 26, 2024 · 19 comments · Fixed by #367
Assignees
Labels
gssoc-ext Indicates Contributions made to GSSoC Extended'24 hacktoberfest-accepted

Comments

@rajdeepchakraborty-rc
Copy link
Contributor

I want to add a Villain page that will feature the villains that Iron Man fought in the MCU universe and comics(since you have that on your site). I will provide a timeline for both, mentioning the most prominent villains(the comics have many villains).

I would like to work on the issue. I will update you about the work progress and share with you to know your feedback along the way. I would request your cooperation and feedback.

@aslams2020
Copy link
Owner

Hi, @rajdeepchakraborty-rc
Will let you know about this, i liked your idea,

@rajdeepchakraborty-rc
Copy link
Contributor Author

@aslams2020 Sure. I came up with this idea as we know many like the hero but also a group of people are interested to know about the villains that the hero has fought. As they make the hero more appealing due to his/her fights.

@rajdeepchakraborty-rc
Copy link
Contributor Author

Hi, @rajdeepchakraborty-rc Will let you know about this, i liked your idea,

@aslams2020 I would request you to let me know soon as the gssoc extended program will end on 31st and I will need some time to work on the issue and complete it.

@aslams2020
Copy link
Owner

Please make a separate page for Villains.

Add the link to that page in the footer of all the pages. by replacing the "Media kit" with "Marvel Villains"
image

@aslams2020 aslams2020 added gssoc-ext Indicates Contributions made to GSSoC Extended'24 hacktoberfest-accepted labels Oct 31, 2024
@aslams2020
Copy link
Owner

level will be assigned based on the work. go ahead.

@rajdeepchakraborty-rc
Copy link
Contributor Author

level will be assigned based on the work. go ahead.

Sure.

@rajdeepchakraborty-rc
Copy link
Contributor Author

@aslams2020 Thanks for assigning the issue to me.
I would like to share a few points with you:

  1. I am currently assigned to a few ongoing issues, and I will need some additional time to complete them before returning to this particular task. I hope this is acceptable to you.
  2. As I am creating an entirely new page, I would appreciate your feedback and input on the progress along the way. I trust that I can count on your support in this regard.

Lastly, please note that while I may require some extra time to address this issue, I am committed to giving my best effort to enhance the project further.

@aslams2020
Copy link
Owner

@rajdeepchakraborty-rc Sure, take time but make sure you complete it too.
You can ask me any doubts regarding it along the way

@rajdeepchakraborty-rc
Copy link
Contributor Author

@rajdeepchakraborty-rc Sure, take time but make sure you complete it too. You can ask me any doubts regarding it along the way

@aslams2020 Thanks for the confirmation. I will let you know when I will start working on the issue.
Please be assured that I am fully committed to completing this task. I will ensure it is finished and try to meet your standards and expectations.

@rajdeepchakraborty-rc
Copy link
Contributor Author

@aslams2020 Once I start working on the issue, I will first share how I want the page to look with you(some sample images to choose from). Please share your opinions on that and let me know your thoughts. I will inform you here when I share the plan.

@rajdeepchakraborty-rc
Copy link
Contributor Author

I am a fan of Iron Man and to be able to work on his legacy and share my knowledge about him with millions of people is a boom to me. I will try to give my best on this issue.

@rajdeepchakraborty-rc
Copy link
Contributor Author

@aslams2020 Let me know if making the villains with such cards will be fine.

After.mp4

This will not be exactly same just let me know if the cards design is fine for your website.

@aslams2020
Copy link
Owner

Yeah it should be fine. The Animation should be somewhat villain themed.

@rajdeepchakraborty-rc
Copy link
Contributor Author

rajdeepchakraborty-rc commented Oct 31, 2024

Yeah it should be fine. The Animation should be somewhat villain themed.

@aslams2020 I think you mean the Deisgn(theme) and not the animation.
Also can you explain what you mean by villain themed?

@aslams2020
Copy link
Owner

The layout can be the same as above (3 columns) ...
Villain themed animation means on hovering the cards should be moved somewhat different than normal flip. (If possible). Otherwise it's on you, how u want you can implement.

@rajdeepchakraborty-rc
Copy link
Contributor Author

The layout can be the same as above (3 columns) ... Villain themed animation means on hovering the cards should be moved somewhat different than normal flip. (If possible). Otherwise it's on you, how u want you can implement.

Ok sure. I will try to look at and implement this feature. I will share it with you if I find something similar to what you want and get your feedback on it.

@rajdeepchakraborty-rc
Copy link
Contributor Author

@aslams2020 Apologies for the delay—I was experimenting with something new. Here’s the result:

Villains_Page.mp4

I considered adding a timeline and took time to learn how to create one. I’d love to hear your thoughts on it. I am still considering any small changes that I feel along the way.

@aslams2020
Copy link
Owner

That's great!
If it's done you can make a PR

@rajdeepchakraborty-rc
Copy link
Contributor Author

That's great! If it's done you can make a PR

Glad you liked it. I will add a few adjustments and then open a PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc-ext Indicates Contributions made to GSSoC Extended'24 hacktoberfest-accepted
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants