Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Villain Page Timeline Image Render #370

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

rajdeepchakraborty-rc
Copy link
Contributor

Related Issue

Description

  1. In the previous PR Added a Villain Page #367, the Villain images were not rendered. Tried to resolve it in this PR.
  2. Renamed the Folder structure I used from Villains to Marvel_Villains to remove ambiguity in existing Villans Folder

Copy link

vercel bot commented Nov 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stark-tech-portfolio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 3, 2024 7:03pm

@rajdeepchakraborty-rc
Copy link
Contributor Author

@aslams2020 Please check the deployment and let me know if the issue is resolved.

Copy link
Owner

@aslams2020 aslams2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved!

@aslams2020 aslams2020 merged commit 3fc6899 into aslams2020:main Nov 4, 2024
3 checks passed
@aslams2020
Copy link
Owner

@rajdeepchakraborty-rc Great work!

@rajdeepchakraborty-rc
Copy link
Contributor Author

@rajdeepchakraborty-rc Great work!

@aslams2020 Thanks a lot! I was looking forward to this contribution, being an Iron Man fan myself. The issue really caused a disturbance in my mind after you informed me about the rendering problem. I wanted to resolve it as soon as possible. I am glad it is working fine now.

Thanks for reviewing the PR and hope you have a great day/night ahead!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants