Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Blogs Page | Issue #255 #295

Merged
merged 3 commits into from
Nov 3, 2024
Merged

Added Blogs Page | Issue #255 #295

merged 3 commits into from
Nov 3, 2024

Conversation

Shariq2003
Copy link
Contributor

fix #255

I have added the Blogs Page that contain the Blogs,

Eg.

  1. Title: The Evolution of Iron Man: From Comic to Cinematic Icon
  • Description: Explore the journey of Tony Stark from his comic book origins to becoming a beloved superhero in the Marvel Cinematic Universe. Discover how Robert Downey Jr.'s portrayal revolutionized superhero films and set the stage for the entire MCU.
  1. Title: Women of Marvel: Breaking Barriers in the MCU
  • Description: A look at the strong female characters in the Marvel Cinematic Universe, from Black Widow to Captain Marvel. This blog post highlights their impact on the franchise and how they inspire audiences worldwide.
  1. Title: The Infinity Saga: A Retrospective on the MCU's Biggest Arcs
  • Description: Dive into the Infinity Saga and revisit the pivotal moments that shaped the Marvel Cinematic Universe. This post covers key films, character arcs, and the interconnected storylines that kept fans on the edge of their seats.
  1. Title: The Future of the MCU: What’s Next for Marvel?
  • Description: Speculations and insights into upcoming Marvel films and TV series. Explore fan theories and the potential direction of the Marvel Cinematic Universe post-Endgame.
    and more.............................
bandicam.2024-10-29.00-24-36-083.mp4

@vercel Vercel
Copy link

vercel bot commented Oct 28, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stark-tech-portfolio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 2, 2024 11:14pm

github-actions[bot]
github-actions bot reviewed Oct 28, 2024
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you for your contribution! Your pull request has been submitted successfully. A maintainer will review it as soon as possible. We appreciate your support in making this project better

aslams2020
aslams2020 requested changes Oct 28, 2024
View reviewed changes
Copy link
Owner

@aslams2020 aslams2020 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The images are not matching with the blog title..
Also the layout, design and everything is the same as "Comics" page. It should be different as these are blogs page.

Add 6 blogs

Please add relevant images to the blogs according to their title, you can refer similar below example
image

@Shariq2003
Copy link
Contributor Author

The images are not matching with the blog title.. Also the layout, design and everything is the same as "Comics" page. It should be different as these are blogs page.

Add 6 blogs

Please add relevant images to the blogs according to their title, you can refer similar below example image

okay

@aslams2020
Copy link
Owner

@Shariq2003 Any updates ?

@Shariq2003
Copy link
Contributor Author

Shariq2003 commented Nov 1, 2024 •
edited
Loading

@aslams2020 sir, I will raise the PR by tonight

aslams2020
aslams2020 reviewed Nov 2, 2024
View reviewed changes
Copy link
Owner

@aslams2020 aslams2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PLease make a new PR @Shariq2003

@Shariq2003
Copy link
Contributor Author

Shariq2003 commented Nov 2, 2024 •
edited
Loading

PLease make a new PR @Shariq2003

okay @aslams2020 sir
Please allow me sometime

@aslams2020
Copy link
Owner

Yeah Sure.

@Shariq2003
Copy link
Contributor Author

Yeah Sure.

Thanks alot sir

@Shariq2003
Copy link
Contributor Author

@aslams2020 sir, Now I have added the 6 Blogs referred from this website LINK
Also, make the page look like a Blogs Page with the theme conservation of the website.

bandicam.2024-11-03.04-42-24-348.mp4

@Shariq2003
Copy link
Contributor Author

@aslams2020 sir, Please review this PR on priority because if you merge any other PR, than this PR will face conflict in the files, as I have also change the navbar for navigation to this page, in multiple pages.

aslams2020
aslams2020 approved these changes Nov 3, 2024
View reviewed changes
Copy link
Owner

@aslams2020 aslams2020 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@aslams2020 aslams2020 added gssoc-ext Indicates Contributions made to GSSoC Extended'24 level2 labels Nov 3, 2024
@aslams2020 aslams2020 merged commit 593a424 into aslams2020:main Nov 3, 2024
3 checks passed
@Shariq2003
Copy link
Contributor Author

@aslams2020 sir, but new page should be of level 3
Am right ?

@aslams2020
Copy link
Owner

Hi @Shariq2003,
Creating a new Page does not actually guarentee a level3. As it is not dependant on number of lines.

i reviewed -

  • In the Blogs page, The navbar and footer are integrated from the homepage (as it should be)
  • The layout of the cards and the styling of them is not newly styled as it is similar to movies and comics pages. Which make no difference in creating a different kind of development idea.
  • Also the page is not responsive

I hope you understand, Why i gave level2 for it.

happy coding!

@Shariq2003
Copy link
Contributor Author

Shariq2003 commented Nov 3, 2024 •
edited
Loading

Hi @Shariq2003, Creating a new Page does not actually guarentee a level3. As it is not dependant on number of lines.

i reviewed -

  • In the Blogs page, The navbar and footer are integrated from the homepage (as it should be)
  • The layout of the cards and the styling of them is not newly styled as it is similar to movies and comics pages. Which make no difference in creating a different kind of development idea.
  • Also the page is not responsive

I hope you understand, Why i gave level2 for it.

happy coding!

@aslams2020 sir Okay what if I make it responsive in my new PR on which you don't have to add any level, just make this PR to level 3, after merging that PR

Fine ?

@aslams2020
Copy link
Owner

aslams2020 commented Nov 3, 2024 •
edited
Loading

I can give that issue's PR Level1.

As this current PR will be a even then a level2, because of the 2nd point. As it is crucial to showcase our developer ideas in whatever work we do.

If you wish to make it responsive, please create an issue first.

@Shariq2003
Copy link
Contributor Author

Shariq2003 commented Nov 3, 2024 •
edited
Loading

I can give that issue's PR Level1.

As this current PR will be a even then a level2, because of the 2nd point. As it is crucial to showcase our developer ideas in whatever work we do.

If you wish to make it responsive, please create an issue first.

Yes sir, I just applied the same styling to match the theme of the website, nothing else.

Okay no problem sir, raising an issue for responsiveness

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@aslams2020 aslams2020 aslams2020 approved these changes

Assignees

@Shariq2003 Shariq2003

Labels
gssoc-ext Indicates Contributions made to GSSoC Extended'24 level2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implementation of Blog Page
2 participants
@Shariq2003 @aslams2020