chore(copybara): sync commits from Aspect-internal silo #551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregmagolan
force-pushed
the
9E6ED7960E7C1C7500F98C1F23B6018B
branch
from
47bfedb to
0ecc574
Compare
fixes following #3715 --- ### Type of change - Chore (any other change that doesn't affect source or test files, such as configuration) ### Test plan - Manual testing; please provide instructions so we can reproduce: `bazel build --repo_env=CACHE=bust --nobuild //...` on macos GitOrigin-RevId: 111389054d2bff339b4b3f2ed11cce70dd1ce66d
Now... 1. Collects named file sets, indexing by fileset id. AFAIU only those produced by the `rules_lint_report` output group will be present 2. Outputs the lint info for a target on `Completed` events. This event provides the label and any associated filesets which we (hopefully) collected Outputting only on the target `Completed` event means the stdout won't be clobbered, or at least not as badly, and it gives us the target name. When running `bazel lint //buildcop/apps/revert/...`: ``` From //buildcop/apps/revert:revert_tests_typings: /private/var/tmp/_bazel_jason/4697ab574309bc992e84a881789f0c91/sandbox/darwin-sandbox/721/execroot/aspect_silo/bazel-out/darwin_arm64-fastbuild/bin/buildcop/apps/revert/test/integration.spec.ts 3:23 error Require statement not part of import statement @typescript-eslint/no-var-requires ✖ 1 problem (1 error, 0 warnings) From //buildcop/apps/revert:revert_typings: /private/var/tmp/_bazel_jason/4697ab574309bc992e84a881789f0c91/sandbox/darwin-sandbox/722/execroot/aspect_silo/bazel-out/darwin_arm64-fastbuild/bin/buildcop/apps/revert/src/entrypoint.ts 2:10 error 'IssueCommentCreatedEvent' is defined but never used @typescript-eslint/no-unused-vars 32:5 error 'context' is defined but never used @typescript-eslint/no-unused-vars /private/var/tmp/_bazel_jason/4697ab574309bc992e84a881789f0c91/sandbox/darwin-sandbox/722/execroot/aspect_silo/bazel-out/darwin_arm64-fastbuild/bin/buildcop/apps/revert/src/github.ts 100:16 error Unexpected any. Specify a different type @typescript-eslint/no-explicit-any ``` GitOrigin-RevId: 3c0f163ccd6d910ed3c17e42d0b31047ddfc6f18
See msolo/jsonr#1 Fix #544 ### Type of change - Bug fix (change which fixes an issue) ### Test plan - New test cases added GitOrigin-RevId: 92a9be946decb95c6af1a2c42621872c9c96ec4f
…#3736) When upgrading the cli at sourcegraph it was generating self-referencing dependencies when a package depended on a typescript `declare module` within the same package. The first comment has some refactoring to organize the logging to be more consistent which I found useful. ### Type of change - Bug fix (change which fixes an issue) - Refactor (a code change that neither fixes a bug or adds a new feature) ### Test plan - Covered by existing test cases - New test cases added GitOrigin-RevId: a590a97ea1c1a9241c7feba373a24de71bbe5b7a
copybara needs update to handle this transform still
gregmagolan
force-pushed
the
9E6ED7960E7C1C7500F98C1F23B6018B
branch
from
a5493a3 to
978914d
Compare
gregmagolan
force-pushed
the
9E6ED7960E7C1C7500F98C1F23B6018B
branch
from
32f8057 to
548f457
Compare
gregmagolan
requested review from
kormide,
jbedard,
CaerusKaru,
JesseTatasciore and
mattem
kormide
approved these changes
Oct 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/4758a88f63e5db51e0e303fbcb1504541ecad0cd..111389054d2bff339b4b3f2ed11cce70dd1ce66d