Reflect tsconfig composite and incremental to ts_project()
#780
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
walkerburgin
force-pushed
the
wburgin/tsconfig
branch
from
673b7f3 to
9e84c24
Compare
jbedard
added a commit
that referenced
this pull request
Dec 13, 2024
…into ts_project() rules (#7460) Synced from #780 by walkerburgin: Reflect tsconfig `composite` and `incremental` to `ts_project()` --- I noticed that `bazel configure` is creating `BUILD.bazel` files that would result in the following error: ``` ERROR: ts_project rule @@//pkgs/foo-lib:typescript was configured with attributes that don't match the tsconfig - attribute composite=false does not match compilerOptions.composite=true - attribute incremental=false does not match compilerOptions.incremental=true You can automatically fix this by running: npx @bazel/buildozer 'set composite True' 'set incremental True' @@//pkgs/foo-lib:typescript Or to suppress this error, either: - pass --norun_validations to Bazel to turn off the feature completely, or - disable validation for this target by running: npx @bazel/buildozer 'set validate False' @@//pkgs/foo-lib:typescript ``` It would be nice for these `compilerOptions` to be automatically mirrored into the `ts_project()`. --- ### Changes are visible to end-users: no ### Test plan - New test cases added Closes #780 Co-authored-by: Walker Burgin <walkerburgin@gmail.com> GitOrigin-RevId: 7897b6f963be24baa3833bf9c39c6287ac8fd383
jbedard
added a commit
that referenced
this pull request
Dec 14, 2024
…into ts_project() rules (#7460) Synced from #780 by walkerburgin: Reflect tsconfig `composite` and `incremental` to `ts_project()` --- I noticed that `bazel configure` is creating `BUILD.bazel` files that would result in the following error: ``` ERROR: ts_project rule @@//pkgs/foo-lib:typescript was configured with attributes that don't match the tsconfig - attribute composite=false does not match compilerOptions.composite=true - attribute incremental=false does not match compilerOptions.incremental=true You can automatically fix this by running: npx @bazel/buildozer 'set composite True' 'set incremental True' @@//pkgs/foo-lib:typescript Or to suppress this error, either: - pass --norun_validations to Bazel to turn off the feature completely, or - disable validation for this target by running: npx @bazel/buildozer 'set validate False' @@//pkgs/foo-lib:typescript ``` It would be nice for these `compilerOptions` to be automatically mirrored into the `ts_project()`. --- ### Changes are visible to end-users: no ### Test plan - New test cases added Closes #780 Co-authored-by: Walker Burgin <walkerburgin@gmail.com> GitOrigin-RevId: 7897b6f963be24baa3833bf9c39c6287ac8fd383
gregmagolan
pushed a commit
that referenced
this pull request
Dec 15, 2024
…into ts_project() rules (#7460) Synced from #780 by walkerburgin: Reflect tsconfig `composite` and `incremental` to `ts_project()` --- I noticed that `bazel configure` is creating `BUILD.bazel` files that would result in the following error: ``` ERROR: ts_project rule @@//pkgs/foo-lib:typescript was configured with attributes that don't match the tsconfig - attribute composite=false does not match compilerOptions.composite=true - attribute incremental=false does not match compilerOptions.incremental=true You can automatically fix this by running: npx @bazel/buildozer 'set composite True' 'set incremental True' @@//pkgs/foo-lib:typescript Or to suppress this error, either: - pass --norun_validations to Bazel to turn off the feature completely, or - disable validation for this target by running: npx @bazel/buildozer 'set validate False' @@//pkgs/foo-lib:typescript ``` It would be nice for these `compilerOptions` to be automatically mirrored into the `ts_project()`. --- ### Changes are visible to end-users: no ### Test plan - New test cases added Closes #780 Co-authored-by: Walker Burgin <walkerburgin@gmail.com> GitOrigin-RevId: 7897b6f963be24baa3833bf9c39c6287ac8fd383
gregmagolan
pushed a commit
that referenced
this pull request
Dec 15, 2024
…into ts_project() rules (#7460) Synced from #780 by walkerburgin: Reflect tsconfig `composite` and `incremental` to `ts_project()` --- I noticed that `bazel configure` is creating `BUILD.bazel` files that would result in the following error: ``` ERROR: ts_project rule @@//pkgs/foo-lib:typescript was configured with attributes that don't match the tsconfig - attribute composite=false does not match compilerOptions.composite=true - attribute incremental=false does not match compilerOptions.incremental=true You can automatically fix this by running: npx @bazel/buildozer 'set composite True' 'set incremental True' @@//pkgs/foo-lib:typescript Or to suppress this error, either: - pass --norun_validations to Bazel to turn off the feature completely, or - disable validation for this target by running: npx @bazel/buildozer 'set validate False' @@//pkgs/foo-lib:typescript ``` It would be nice for these `compilerOptions` to be automatically mirrored into the `ts_project()`. --- ### Changes are visible to end-users: no ### Test plan - New test cases added Closes #780 Co-authored-by: Walker Burgin <walkerburgin@gmail.com> GitOrigin-RevId: 7897b6f963be24baa3833bf9c39c6287ac8fd383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that
bazel configureis creatingBUILD.bazelfiles that would result in the following error:It would be nice for these
compilerOptionsto be automatically mirrored into thets_project().Changes are visible to end-users: yes
Test plan