process: sync commits from Aspect-internal silo#801
Merged
Conversation
|
jbedard
force-pushed
the
788EA150BB0FAAB4A3FF81F26DCBE189
branch
2 times, most recently
from
894ac73 to
2b91007
Compare
Bedrock Robotics has the BB CLI enabled and wants to run BB In parallel with Workflows during the trial. BB CLI has badly formatted output for the `bazel help flags-as-proto` command which the Aspect CLI makes which break the base64 decode. This change sanitizes the output of the `help flags-as-proto` command so that Workflows can handle the BB CLI configured in a `.bazeliskrc` file. --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Workflows now sanitizes the output of `bazel help flags-as-proto` in order the handle the BuildBuddy CLI configured in a repos `.bazeliskrc` file (for example `USE_BAZEL_VERSION=buildbuddy-io/5.0.112`). ### Test plan - Manual testing; please provide instructions so we can reproduce: Tested with a `.bazeliskrc`: ``` USE_BAZEL_VERSION=buildbuddy-io/5.0.112 ``` https://buildkite.com/aspect-build/silo-aws/builds/30559#_ GitOrigin-RevId: e05315c917873baeff904c9ccd550e4b16e51cb6
Found a weird issue in the CLI where if you run this command it fails silently: ``` bazel build //cli/pro && bazel-bin/cli/pro/pro_/pro outputs ExecutableHash ``` This change allows the error to show up but I do not understand why --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases - New test cases added - Manual testing; please provide instructions so we can reproduce: GitOrigin-RevId: ea05475612ecc74bfe0889a4984589713c84d476
Change the npm package resolution to a gazelle `CrossResolver` so other gazelle languages (such as orion) can resolve npm dependencies. The first commit just moves code around so the main commit has a simpler diff. --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Support BUILD-generation dependencies on npm packages from other gazelle languages such as orion. ### Test plan - Covered by existing test cases - New test cases added GitOrigin-RevId: a3779b341711d5bb4ab89fd9ad7f005352e27e64
…(#7716) I'm pretty sure the `.Fatal` call outputs to stdout in the cli but it was not shown in stdout of the gazelle tests. --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases - Manual testing; please provide instructions so we can reproduce: run tests failing due to this error, it should report the stdout GitOrigin-RevId: 7d55ba711e0f4425214c33ff2f8e47100b8477eb
There is now a marvin specific for skipped targets as well as an animated one for ongoing builds. Fixes #7230 --- ### Changes are visible to end-users: no ### Test plan - Manual testing; please provide instructions so we can reproduce: Posted a gif of the ongoing marvin to slack :) GitOrigin-RevId: 883121b9c0c17ef2e84bc6246909ef9b9d4c66bd
Our bazel-examples repo doesn't have a WORKSPACE file currently. Patches bazel-contrib/bazel-gazelle#2013 --- ### Changes are visible to end-users: no ### Test plan - Manual testing; please provide instructions so we can reproduce: Built the CLI and ran it in `bazel-examples` repo, this error goes away: ``` Error: -repo_root not specified, and WORKSPACE cannot be found: file does not exist ``` GitOrigin-RevId: 389c7cee67922c4d62c956322d94883ec727ae57
This brings the feature that https://github.com/aspect-build/plugin-augment-error adds to Aspect CLI and bakes it into the Aspect CLI itself as a "hints" feature configured in the `.aspect/cli/config.yaml` file via a top-level `hints` attribute that is a map of regex to hint/suggestion. For example: ``` hints: foo: bar bar: fum ``` will produce the following output after the Aspect CLI command is run if `foo` and `bar` are present in the output: ``` ------------------------------------------------------------------------------------------ | [Aspect CLI] | | | | - bar | | - fum | ------------------------------------------------------------------------------------------ ``` The reasoning behind hoisting this feature to be a first-class citizen of the Aspect CLI is that not all of Bazel's output is present in the ProgressMessage BES event, which the plugin-augment-error, scans. For some use cases the error is only present in the stdout/stderr of Bazel which makes it impossible to hint on when using the plugin-augment-error. --- - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Aspect CLI now supports adding "hints" in the Aspect CLI config file. This is a map of regex to hint/suggestion that will be displayed when the regex matches in stdout or stderr of the command. - Manual testing; please provide instructions so we can reproduce: Manually tested with locally build Aspect CLI these changes. The stdout/stderr stream attachment is only made if there are hints configured so the change is low risk. Will add automated tests in a follow-up PR. GitOrigin-RevId: 1e1f8f80986523705b1cd7108b337d231f2960c4
- Fixes multi-line hint formatting - Strips color codes before regex matching - Trims leading and trailing whitespace from line Added a unit test. --- ### Changes are visible to end-users: no Not yet released so doesn't affect users. ### Test plan - New test cases added GitOrigin-RevId: e9f675504761db7f2e945495ddd5561d2c6aca35
Nothing uses it yet, working on a trivial query test. --- ### Changes are visible to end-users: no ### Test plan - Manual testing; please provide instructions so we can reproduce: Will add in another commit GitOrigin-RevId: 88b20590f741f370d39aa0eacef718f7f6be72f9
- Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Support yaml queries in orion plugins using the yq/jq query language. - New test cases added GitOrigin-RevId: 34702afbb6022cbbc19e70da86ead975fa8e1939
…butes (#7803) Attributes need to be marked as "mergeable" for gazelle to support things like `# keep` comments on these attributes. --- ### Changes are visible to end-users: yes - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: yes Fix `# keep` directives on tsconfig related attributes with `aspect configure`. ### Test plan - New test cases added GitOrigin-RevId: 9d0fa13abe35369fa9bbed1f9958a7b1c0939d40
### Changes are visible to end-users: no - Searched for relevant documentation and updated as needed: yes - Breaking change (forces users to change their own code or config): no - Suggested release notes appear below: no ### Test plan - Covered by existing test cases GitOrigin-RevId: 7885b2a69b66841a9831112b447965f7ef8e9cc9
…(#7334) An opt-in (via env var) POC to show progress, I found it interesting 🤷 --- ### Changes are visible to end-users: no ### Test plan - Manual testing; please provide instructions so we can reproduce: run the cli with the opt-in var TODO: * respect the bazel `--[no]show_progress` GitOrigin-RevId: c11291c5390f1e94e032c757631981fac764b52c
### Changes are visible to end-users: no ### Test plan - Manual testing; please provide instructions so we can reproduce: feature still works, but no longer directly imports golang/x/sys/unix GitOrigin-RevId: ffaf120902c3bf478cba7bfff9d0ce3af4613be6
…n (#7840) Found while using rules_jvm tests in a java plugin poc. --- ### Changes are visible to end-users: no ### Test plan - New test cases added GitOrigin-RevId: 8a5d4e12ecf1f60e6eb344e996394e8fad5c7568
I can't reproduce it with a real gazelle test, but this index out of bounds was reported at a client and is an easy fix. ### Changes are visible to end-users: no ### Test plan - New test cases added GitOrigin-RevId: e9897a99d13ac7d7b4963d41e2b3e603410e59f5
… (#7843) All generated js-related rules should persist this so the data (mainly which source files are in it) doesn't have to be re-computed later. When this data does not exist (such as rules not generated, or npm package targets before this fix) then the rule is inspected to find this which sometimes includes globbing the fs. Note this exact line exists already for generated `ts_project` or `js_library` targets, it is just the "package" target here where it was missing (which might be `npm_package` or `js_library`). --- ### Changes are visible to end-users: no ### Test plan - Covered by existing test cases GitOrigin-RevId: d9eb92d2924a59edf2c42f9c342a1c9b1873e7c6
jbedard
force-pushed
the
788EA150BB0FAAB4A3FF81F26DCBE189
branch
from
c7e32af to
455b1a5
Compare
thesayyn
approved these changes
Jan 22, 2025
Member
thesayyn
left a comment
thesayyn
left a comment
There was a problem hiding this comment.
LGTM, but windows should be fixed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit range https://github.com/aspect-build/silo/compare/f9606bfafdbd60739f51f57c15242c9a4c9a87a5..d9eb92d2924a59edf2c42f9c342a1c9b1873e7c6