fix: include package store directory in default output of npm_link_pa…

…ckage_store
aspect-build · May 28, 2024 · 50dfb58 · 50dfb58
1 parent 31118a6
commit 50dfb58
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/examples/genrule/BUILD.bazel b/examples/genrule/BUILD.bazel
@@ -33,7 +33,6 @@ genrule(
         ":one.js",
         # reference the location where the "acorn" npm package was linked in our root Bazel package.
         "//:node_modules/acorn",
-        "//:node_modules/acorn/dir",
     ],
     outs = ["out1"],
     cmd = " ".join([
@@ -69,7 +68,6 @@ genrule(
         ":require_acorn_js",
         # reference the location where the "acorn" npm package was linked in our root Bazel package.
         "//:node_modules/acorn",
-        "//:node_modules/acorn/dir",
     ],
     outs = ["out2"],
     cmd = """

diff --git a/npm/private/npm_link_package_store.bzl b/npm/private/npm_link_package_store.bzl
@@ -92,7 +92,7 @@ def _npm_link_package_store_impl(ctx):
         )
         files.append(bin_file)
 
-    files_depset = depset(files)
+    files_depset = depset(files, transitive = [store_info.files])
 
     transitive_files_depset = depset(files, transitive = [store_info.transitive_files])