-
-
Notifications
You must be signed in to change notification settings - Fork 107
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: support pnpm.onlyBuiltDependencies #1723
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbedard
force-pushed
the
1689-only-build-deps
branch
from
May 14, 2024 17:16
aa4d0ce
to
e70a4ba
Compare
gregmagolan
reviewed
May 14, 2024
jbedard
force-pushed
the
1689-only-build-deps
branch
3 times, most recently
from
May 14, 2024 19:53
195f3a5
to
4675241
Compare
gregmagolan
reviewed
May 14, 2024
gregmagolan
approved these changes
May 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🌮
jbedard
force-pushed
the
1689-only-build-deps
branch
from
May 14, 2024 20:55
4675241
to
7c8f829
Compare
jbedard
added a commit
to jbedard/rules_js
that referenced
this pull request
May 16, 2024
gregmagolan
pushed a commit
that referenced
this pull request
May 20, 2024
gregmagolan
pushed a commit
that referenced
this pull request
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes are visible to end-users: yes
The pnpm.onlybuiltdependencies is now respected for lifecycle hooks. If specified only the packages listed in
pnpm.onlybuiltdependencies
will run lifecycle hooks.Test plan