generated from bazel-contrib/rules-template
-
-
Notifications
You must be signed in to change notification settings - Fork 82
feat: add Standard Ruby linter support #652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cgrindel
wants to merge
5
commits into
aspect-build:main
Choose a base branch
from
cgrindel:add_standardrb
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Standard Ruby (standardrb) as a Ruby linter alongside RuboCop. This implementation follows the same pattern as the RuboCop integration with full support for linting, auto-fixing, and SARIF report generation. Key changes: - Add lint/standardrb.bzl with lint_standardrb_aspect for Ruby linting - Update example configuration with standardrb gem dependency (v1.51.1) - Add .standard.yml configuration file for the example project - Integrate standardrb into the example tooling and test suite - Add test expectations for Standard Ruby linting violations - Update README.md to document Standard Ruby support - Pin gem versions in MODULE.bazel and WORKSPACE.bazel for reproducible builds Standard Ruby is a zero-configuration Ruby linter and formatter based on RuboCop. It provides stricter defaults and enforces a consistent style guide. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
Address code review findings: - Add --force-exclusion flag in standardrb_action() to honor exclusions from .standard.yml even when explicit files are passed - Add --force-exclusion flag in JSON output action for consistency - Update Gemfile to use ~> version constraint for standard gem to match RuboCop pattern and prevent breaking changes This ensures Standard Ruby respects exclusion patterns defined in configuration files, matching the behavior of the RuboCop implementation. 🤖 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com>
|
Ensure all lines in lint/standardrb.bzl adhere to the 80 character limit for Starlark files per project conventions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.


Summary
Add support for Standard Ruby (standardrb) as a Ruby linter alongside RuboCop. This implementation follows the same pattern as the RuboCop integration with full support for linting, auto-fixing, and SARIF report generation.
Standard Ruby is a zero-configuration Ruby linter and formatter based on RuboCop that provides stricter defaults and enforces a consistent style guide.
Implementation
Key Changes
lint/standardrb.bzlwithlint_standardrb_aspectfor Ruby linting.standard.ymlconfiguration file for the example projectImplementation Details
.standard.ymlconfiguration/tmpfor cache directory to avoid workspace pollution--force-exclusionflag to respect exclusion patterns🤖 Generated with Claude Code