Skip to content

Commit

Permalink
feat: specify tsc outputs in action progress message
Browse files Browse the repository at this point in the history
  • Loading branch information
jbedard committed Oct 24, 2024
1 parent 41a2678 commit 70d0c14
Showing 1 changed file with 5 additions and 4 deletions.
9 changes: 5 additions & 4 deletions ts/private/ts_project.bzl
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,6 @@ See https://github.com/aspect-build/rules_ts/issues/361 for more details.
# Not emitting declarations
tsc_emit_arguments.add("--declaration", "false")

verb = "Transpiling" if ctx.attr.isolated_typecheck else "Transpiling & type-checking"

inputs_depset = inputs if ctx.attr.isolated_typecheck else transitive_inputs_depset

if supports_workers:
Expand All @@ -299,8 +297,11 @@ See https://github.com/aspect-build/rules_ts/issues/361 for more details.
mnemonic = "TsProjectEmit" if ctx.attr.isolated_typecheck else "TsProject",
execution_requirements = execution_requirements,
resource_set = resource_set(ctx.attr),
progress_message = "%s TypeScript project %s [tsc -p %s]" % (
verb,
progress_message = "Transpiling%s%s TypeScript project %s [tsc -p %s]" % (
# Mention what is being emitted if not both
"" if use_tsc_for_dts and use_tsc_for_js else " (dts)" if use_tsc_for_dts else " (js)",
# Mention type-checking if done in this action
" & type-checking" if not ctx.attr.isolated_typecheck else "",
ctx.label,
tsconfig_path,
),
Expand Down

0 comments on commit 70d0c14

Please sign in to comment.