Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: upgrade to latest bazel 7.3.2 #718

Merged
merged 1 commit into from
Oct 19, 2024
Merged

Conversation

jbedard
Copy link
Member

@jbedard jbedard commented Oct 16, 2024

Changes are visible to end-users: no

Test plan

  • Covered by existing test cases

Copy link

aspect-workflows bot commented Oct 16, 2024

Test

All tests were cache hits

140 tests (100.0%) were fully cached saving 8s.


Buildifier      Format

@jbedard jbedard force-pushed the bazel73 branch 2 times, most recently from 6c0bea5 to ecd7499 Compare October 17, 2024 02:53
@jbedard jbedard marked this pull request as ready for review October 17, 2024 02:57
@jbedard jbedard requested a review from dzbarsky October 17, 2024 04:31
@gregmagolan
Copy link
Member

XDG_CACHE_HOME is also problematic for other reasons: bazel-contrib/bazel-lib#914 (comment)

@jbedard jbedard enabled auto-merge (rebase) October 17, 2024 19:23
@jbedard jbedard disabled auto-merge October 17, 2024 19:27
@jbedard jbedard force-pushed the bazel73 branch 2 times, most recently from afb18ef to 9957a21 Compare October 18, 2024 21:47
@jbedard
Copy link
Member Author

jbedard commented Oct 18, 2024

@gregmagolan I have no idea what the latest error is and haven't been able to figure it out 🤷

(22:58:41) ERROR: /home/runner/work/rules_ts/rules_ts/docs/BUILD.bazel:5:23: in deps attribute of starlark_doc_extract rule //docs:rules.extract: missing bzl_library targets for Starlark module(s) @platforms//host:constraints.bzl. Since this rule was created by the macro 'stardoc_with_diff_test', the error might have been caused by the macro implementation

@gregmagolan
Copy link
Member

gregmagolan commented Oct 19, 2024

@gregmagolan I have no idea what the latest error is and haven't been able to figure it out 🤷

(22:58:41) ERROR: /home/runner/work/rules_ts/rules_ts/docs/BUILD.bazel:5:23: in deps attribute of starlark_doc_extract rule //docs:rules.extract: missing bzl_library targets for Starlark module(s) @platforms//host:constraints.bzl. Since this rule was created by the macro 'stardoc_with_diff_test', the error might have been caused by the macro implementation

Need to update bazel-lib to a minimum of 2.9.0 to pickup bazel-contrib/bazel-lib#914. But can't do that since there is a regression in bsdtar-prebuild in 3.7.5 that breaks the tar toolchain. Possibly due to libarchive 3.7.5 regression mentioned in https://github.com/libarchive/libarchive/releases/tag/v3.7.6?

So first have to verify that libarchive 3.7.7 fixes the regression in bsdtar-prebuilt (we caught the failure in silo when trying to bump to latest bazel-lib). Then can land an update to bazel-lib and then can update rules_js & friends minimum bazel-lib to green this up.

@gregmagolan
Copy link
Member

gregmagolan commented Oct 19, 2024

After bazel-contrib/bazel-lib#969 lands and bazel-lib 2.9.3 release is cut then this can be greened up

@gregmagolan gregmagolan force-pushed the bazel73 branch 11 times, most recently from c98c3c6 to 82b981b Compare October 19, 2024 07:43
@gregmagolan gregmagolan merged commit a058043 into aspect-build:main Oct 19, 2024
24 checks passed
@jbedard jbedard deleted the bazel73 branch October 21, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants