Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "refactor: only pass --outDir flag when needed" #722

Closed
wants to merge 1 commit into from

Conversation

alexeagle
Copy link
Member

Reverts #720

Seeing this failure in Aspect's monorepo after upgrade:

Action details (uncached result): http://localhost:7984/blobs/sha256/historical_execute_response/04ad170125e75a56633cd628f1782dbc11b6a2a9a4171f89593d27f6b6d3625f-1170/
/build/root/b098cf6924e0b469/root/bazel-out/k8-fastbuild/bin/node_modules/.aspect_rules_js/liquidjs@10.9.2/node_modules/liquidjs/dist/liquid.node.cjs.js:2310
        const taskOrTpl = sync ? yield task : toPromise(task);
                                 ^
 
Error: ENOENT: Failed to lookup "/build/root/b098cf6924e0b469/root/bazel-out/k8-fastbuild/bin/workflows/marvin/domain/templates/comment.liquid" in "."
    at Loader.lookupError (/build/root/b098cf6924e0b469/root/bazel-out/k8-fastbuild/bin/node_modules/.aspect_rules_js/liquidjs@10.9.2/node_modules/liquidjs/dist/liquid.node.cjs.js:2252:21)
    at Loader.lookup (/build/root/b098cf6924e0b469/root/bazel-out/k8-fastbuild/bin/node_modules/.aspect_rules_js/liquidjs@10.9.2/node_modules/liquidjs/dist/liquid.node.cjs.js:2220:20)
    at lookup.next (<anonymous>)

needs a repro here before we try to roll-forward

Copy link

aspect-workflows bot commented Oct 21, 2024

Test

All tests were cache hits

140 tests (100.0%) were fully cached saving 8s.


Buildifier      Format

@alexeagle alexeagle closed this Oct 21, 2024
@jbedard jbedard deleted the revert-720-outdir_59036 branch October 21, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant