Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: specify tsc outputs in action progress message #724

Merged
merged 1 commit into from
Oct 24, 2024
+5 −4
Merged

feat: specify tsc outputs in action progress message #724

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions ts/private/ts_project.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -283,8 +283,6 @@ See https://github.com/aspect-build/rules_ts/issues/361 for more details.
# Not emitting declarations
tsc_emit_arguments.add("--declaration", "false")

verb = "Transpiling" if ctx.attr.isolated_typecheck else "Transpiling & type-checking"

inputs_depset = inputs if ctx.attr.isolated_typecheck else transitive_inputs_depset

if supports_workers:
Expand All @@ -299,8 +297,11 @@ See https://github.com/aspect-build/rules_ts/issues/361 for more details.
mnemonic = "TsProjectEmit" if ctx.attr.isolated_typecheck else "TsProject",
execution_requirements = execution_requirements,
resource_set = resource_set(ctx.attr),
progress_message = "%s TypeScript project %s [tsc -p %s]" % (
verb,
progress_message = "Transpiling%s%s TypeScript project %s [tsc -p %s]" % (
# Mention what is being emitted if not both
"" if use_tsc_for_dts and use_tsc_for_js else " (dts)" if use_tsc_for_dts else " (js)",
# Mention type-checking if done in this action
" & type-checking" if not ctx.attr.isolated_typecheck else "",
ctx.label,
tsconfig_path,
),
Expand Down
Loading