Skip to content
This repository has been archived by the owner on Oct 31, 2024. It is now read-only.

Document supported versions #239

Open
punya opened this issue Aug 15, 2022 · 3 comments
Open

Document supported versions #239

punya opened this issue Aug 15, 2022 · 3 comments

Comments

@punya
Copy link

punya commented Aug 15, 2022

Thank you for building these instrumentation libraries!

When looking at the instrumentation libraries in https://github.com/open-telemetry/opentelemetry-js-contrib/tree/main/plugins/node, I found it very useful to see the supported versions listed for each library (i.e., the versions of foo supported by @opentelemetry/instrumentation-foo).

Would it be possible to add something similar to the libraries in this repo? I'm especially curious if the Mongoose instrumentation supports Mongoose v6.

@blumamir
Copy link
Contributor

Hi @punya
Thank you for your interest. I too think it could be great to add this information to the README.
Would you be interested in contributing a PR that adds this info?

The mongoose instrumentation will soon be upstreamed to the contrib repo, so I can also add this info when migrating the code there.

@punya
Copy link
Author

punya commented Aug 18, 2022

I don't know what versions are supported, so I'm not sure how I'd make that PR!

@blumamir
Copy link
Contributor

upstream the instrumentation to contrib repo, with test-all-version, support for v6 and documentation in README

open-telemetry/opentelemetry-js-contrib#1131

Thanks for bringing it up :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants