This repository has been archived by the owner on Oct 31, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request contains a number of updates across the codebase, primarily focused on upgrading dependencies and adjusting code to align with these updates. The changes span across multiple files, including GitHub workflow files, package.json files in various directories, and several TypeScript files.
The key changes can be grouped into three main categories:
1. Updates to GitHub workflow files:
.github/workflows/daily-test.yml
and.github/workflows/test.yml
: The Neo4j image version was updated from 4.2.3 to 4.4.34, and theNEO4J_AUTH
environment variable was changed fromneo4j/test
toneo4j/your_password
. Additionally, the Node.js version used was updated from 14 to 18. [1] [2] [3]2. Updates to package.json files:
package.json
files in various directories (detectors/node/resource-detector-deployment
,detectors/node/resource-detector-git
,detectors/node/resource-detector-service
,detectors/resource-detector-sync-api
,packages/instrumentation-elasticsearch
,packages/instrumentation-express
): These files saw updates to their dependencies, with versions of@opentelemetry/api
,@opentelemetry/resources
,@opentelemetry/semantic-conventions
,ts-node
, andtypescript
being updated. Theopentelemetry-instrumentation-mocha
dependency was replaced withaspecto-opentelemetry-instrumentation-mocha
. [1] [2] [3] [4] [5] [6]lerna.json
andpackage.json
at the root level: TheuseWorkspaces
property was removed fromlerna.json
, and thepostinstall
script and the version ofprettier
were updated inpackage.json
. [1] [2]3. Updates to TypeScript files:
packages/instrumentation-elasticsearch/src/elasticsearch.ts
andpackages/instrumentation-elasticsearch/src/utils.ts
: These files saw changes to the import statements forSemanticAttributes
from@opentelemetry/semantic-conventions
, replacing them with specific semantic attributes. There were also several changes in theElasticsearchInstrumentation
class and thestartSpan
andgetNetAttributes
functions to use the new semantic attributes. [1] [2] [3] [4] [5] [6] [7]packages/instrumentation-elasticsearch/test/utils.spec.ts
: The import statement forSemanticAttributes
was updated, and the test cases were adjusted to use the new semantic attributes. [1] [2] [3]