-
-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update for 2024 #27
Update for 2024 #27
Conversation
This reverts commit cf1aaed.
There are multiple things going on here within one pull-request:
It's not working well to review all these changes within one PR. Change 1 deserves a separate PR as originally described. It's a major overhaul (conceptually) that should not be mixed with other changes. I think it could also benefit from a bit more explanation in the readme on how it works and especially how people can now (more easily!) contribute. The changes to 2 could be easily merged. Changes to 3 have some discussion that holds up the review (the comment of Rens above seems like a way in which this can be done but also requires those figures to be updated when ASReview is updated, is that reasonable additional work to put on the developers of the frontend?). It's not nice that for instance textual changes are hold up by an overhaul of the way the website is rendered. This can be avoided by pulling apart these pull-request. @jteijema please create 3 separate pull-requests would allow for better review and discussion. |
1 and 3 are inherently linked; the changing of figures and their location is managed differently because of the changing to the generation of the html files (i.e. the workflow manages image location). I agree that we can move the changes for point 2 to a different PR. We needed the updated site for the latest summer school and we wanted to avoid pointing the users to even more websites. |
Alright, then let's try to make it work for now. Let's try the following solution:
If we do this, control and responsibility for the correctness of the screenshots is fully in this repo itself. That takes away any need for asreview main repo maintainers to think about these screenshots when they update. We will follow their work when updating tutorials. |
Figures and content have been solved in #28 The GitHub actions should be a new PR. |
Decided on a makeover. Let's automate the generation of the html files with a github workflow