OUT-2986 | Implement fetching Assembly invoice, contracts and forms counts in API #27
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
priosshrsth
approved these changes
Feb 6, 2026
Collaborator
priosshrsth
left a comment
priosshrsth
left a comment
There was a problem hiding this comment.
minor optional feedback but otherwise lgtm.
SandipBajracharya
requested changes
Feb 6, 2026
| if (typeof rule === 'string') return rule === pathname | ||
| if (rule.path !== pathname) return false | ||
| const pathMatches = (pattern: string, pathname: string): boolean => { | ||
| const regex = pattern.replace(/:[^/]+/g, '[^/]+').replace(/\//g, '\\/') |
Collaborator
There was a problem hiding this comment.
It would be helpful if we add some docs to what this function actually does.
| id: z.string(), | ||
| recipientClientId: z.uuid(), | ||
| recipientCompanyId: z.uuid().nullish(), | ||
| event: z.string(), |
Collaborator
There was a problem hiding this comment.
Can we also parse this event with NotificationEvent from notification-counts/types.ts? With this I think we don't have to do const key = this.eventMap[event as NotificationEvent] in notification-counts.service file right?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
notification-countsfeature to get invoice, contracts & forms counts via list notificationsTesting Criteria