Skip to content

OUT-2711 | can't change the size of a video embed in the home app #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
arpandhakal wants to merge 1 commit into
base: main
Choose a base branch
from
Open

OUT-2711 | can't change the size of a video embed in the home app #120

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,7 @@
"copilot-node-sdk": "^3.12.1",
"handlebars": "^4.7.8",
"http-status": "^1.7.4",
"link-to-iframe": "^1.0.8",
"next": "latest",
"p-retry": "^6.2.1",
"prisma": "^5.6.0",
Expand Down
7 changes: 6 additions & 1 deletion src/components/tiptap/iframe/EmbedComponent.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@ import { Resize } from '../image/resizeIcon'
import { useAppState } from '@/hooks/useAppState'
import { usePathname } from 'next/navigation'
import { debounce } from '@mui/material'
import { IframeAttributes, linkToIframe } from 'link-to-iframe'

export const EmbedComponent = (props: any) => {
const [isResizing, setIsResizing] = useState(false)
Expand Down Expand Up @@ -52,6 +53,9 @@ export const EmbedComponent = (props: any) => {

const appState = useAppState()
const pathname = usePathname()
const video = linkToIframe(extractIframeSrc(props.node.attrs.src), {
returnObject: true,
}) as IframeAttributes //safe to do. returnObject: true always returns an IframeAttributes object.

return (
<NodeViewWrapper className='embed relative'>
Expand All @@ -63,13 +67,14 @@ export const EmbedComponent = (props: any) => {
}}
>
<iframe
src={extractIframeSrc(props.node.attrs.src)}
src={video?.src}
width='100%'
height='100%'
onError={(e) => {
e.stopPropagation()
console.info('[iframe error]:', e)
}}
allowFullScreen
/>
</div>
{!pathname.includes('client-preview') && !appState?.appState.readOnly && (
Expand Down
5 changes: 5 additions & 0 deletions yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5762,6 +5762,11 @@ lines-and-columns@^1.1.6:
resolved "https://registry.yarnpkg.com/lines-and-columns/-/lines-and-columns-1.2.4.tgz#eca284f75d2965079309dc0ad9255abb2ebc1632"
integrity sha512-7ylylesZQ/PV29jhEDl3Ufjo6ZX7gCqJr5F7PKrqc93v7fzSymt1BpwEU8nAUXs8qzzvqhbjhK5QZg6Mt/HkBg==

link-to-iframe@^1.0.8:
version "1.0.8"
resolved "https://registry.yarnpkg.com/link-to-iframe/-/link-to-iframe-1.0.8.tgz#dab3e714477174364071bb74d5fd44460941b3e7"
integrity sha512-CxVz2rd7k8vudDe4q+LCbSBuReKEozH+7KXqYWgGuTV/bor9gNUilPMnXkRvtn1b087fSOicLRIBHe6AUvGLXA==

linkify-it@^4.0.1:
version "4.0.1"
resolved "https://registry.yarnpkg.com/linkify-it/-/linkify-it-4.0.1.tgz#01f1d5e508190d06669982ba31a7d9f56a5751ec"
Expand Down
Loading