OUT-3045: retry mechanisms for dropbox rate limit or server error #81
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] trigger retry when hitting dropbox rate limit or server error - [x] logic to handle dropbox rate limit case and retry after specified time in response header
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
arpandhakal
approved these changes
Feb 3, 2026
Comment on lines
-73
to
-81
| if (!response.ok) { | ||
| const retryAfter = response.headers.get('Retry-After') | ||
| const error = new Error(`Request failed with status ${response.status}`) as StatusableError | ||
| error.status = response.status | ||
| error.retryAfter = retryAfter ? parseInt(retryAfter, 10) : undefined | ||
| throw error | ||
| } | ||
|
|
||
| return response |
Collaborator
There was a problem hiding this comment.
Arent we going to throw DropboxResponseError from manual fetch from the DropboxAPI?
Collaborator
Author
There was a problem hiding this comment.
The reason I removed this is because we can customize the error message from the function level that uses this manualFetch and we don't have to use try catch again.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing Criteria
Loom