OUT-3065 | Resync files that are failed to upload #86
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| await resyncFailedFilesInAssembly.trigger({ | ||
| portalId, | ||
| failedSyncs: failedSyncsForPortal, | ||
| }) |
There was a problem hiding this comment.
Are we okay with all these jobs being run in parallel? Like, we won't get ratelimited by Assembly or Dbx side?
There was a problem hiding this comment.
The job is calling a service where bottleneck is applied for parallel processing. Also, there aren't much files that are failing, so its safe to let things pass for now.
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
| export const resyncFailedFiles = async (request: NextRequest) => { | ||
| const authHeader = request.headers.get('authorization') | ||
| if (authHeader !== `Bearer ${env.CRON_SECRET}`) { | ||
| throw new APIError('Unauthorized', 401) |
There was a problem hiding this comment.
Can we use httpStatus.UNAUTHORIZED here for consistency?
| }, | ||
| }) | ||
|
|
||
| export const resyncFailedFilesInAssembly = task({ |
There was a problem hiding this comment.
We should also consider defining machine here since single portal could have many files and can be long running as well. We have TRIGGER_MACHINE env that you can import from server.env.ts file and use that here.
|
|
||
| for (const portalId in failedSyncWorkspaceMap) { | ||
| const failedSyncsForPortal = failedSyncWorkspaceMap[portalId] | ||
| await resyncFailedFilesInAssembly.trigger({ |
There was a problem hiding this comment.
If the intention is to await for the trigger task here, it won't work. This is the nature of the task unless we do triggerAndWait which can only be done from another trigger task.
3 participants
Changes