Skip to content

OUT-2956: throw error to capture exception for sentry #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
SandipBajracharya merged 1 commit into from
Jan 21, 2026
Merged

OUT-2956: throw error to capture exception for sentry #187

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/hook/useQuickbooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
return () => {
supabase.removeChannel(realtimeSyncChannel)
}
}, [])

Check warning on line 98 in src/hook/useQuickbooks.ts

View workflow job for this annotation

GitHub Actions / Run linters 

React Hook useEffect has missing dependencies: 'setAppParams' and 'tokenPayload?.workspaceId'. Either include them or remove the dependency array

// handle reconnect logic
useEffect(() => {
Expand All @@ -107,7 +107,7 @@
if (reconnect) {
handleAppConnect()
}
}, [reconnect])

Check warning on line 110 in src/hook/useQuickbooks.ts

View workflow job for this annotation

GitHub Actions / Run linters 

React Hook useEffect has a missing dependency: 'handleConnect'. Either include it or remove the dependency array

const getAuthUrl = async (type?: string) => {
setLoading(true)
Expand Down Expand Up @@ -228,9 +228,11 @@
)
setLoading(false)
if (!res.ok) {
console.error({ res })
const respBody = await res.json()
const error =
respBody.error || 'handleError :: Error connecting to QuickBooks'
setError('Error connecting to QuickBooks')
return
throw new Error(error)
}
}

Expand All @@ -254,9 +256,12 @@

setLoading(false)
if (!res.ok) {
console.error({ res })
const respBody = await res.json()
const error =
respBody.error ||
'handleTokenExchange :: Error connecting to QuickBooks'
setError('Error connecting to QuickBooks')
return
throw new Error(error)
}

// auto close the current window after 2 seconds
Expand Down
Loading