Skip to content

fix(OUT-3081): preserve QB default class on invoice line items #190

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
aschwartz91 wants to merge 2 commits into from
Closed

fix(OUT-3081): preserve QB default class on invoice line items #190

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
af161f3
fix: preserve QB default class on invoice line items by omitting Clas…
aschwartz91 Feb 5, 2026
726e2a7
fix: forward ClassRef for newly created/found-by-name QB items
aschwartz91 Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/app/api/quickbooks/invoice/invoice.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,7 +326,7 @@
syncLogConditions,
)

return { ref: { value: qbItem.Id }, productDescription }
return { ref: { value: qbItem.Id }, productDescription, classRef: qbItem.ClassRef }

Check failure on line 329 in src/app/api/quickbooks/invoice/invoice.service.ts

View workflow job for this annotation

GitHub Actions / Run linters 

Replace `·ref:·{·value:·qbItem.Id·},·productDescription,·classRef:·qbItem.ClassRef` with `⏎······ref:·{·value:·qbItem.Id·},⏎······productDescription,⏎······classRef:·qbItem.ClassRef,⏎···`
}

private async prepareLineItemPayload(
Expand Down Expand Up @@ -363,9 +363,9 @@
// Doc reference: https://developer.intuit.com/app/developer/qbo/docs/workflows/manage-sales-tax-for-us-locales#specifying-sales-tax
value: 'TAX',
},
// classrRef is optional. ClassRef to reference the associated class of the QB item.
// ClassRef is optional. Only include when we have a value, otherwise QB will use the item's default class.
// Doc reference: https://developer.intuit.com/app/developer/qbo/docs/api/accounting/all-entities/class
ClassRef: itemRef.classRef,
...(itemRef.classRef && { ClassRef: itemRef.classRef }),
},
Description:
typeof itemRef.productDescription === 'undefined'
Expand Down
Loading