Feature/api improvements #1101
Open
Feature/api improvements #1101
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…llBar component from details page
- created a separate RealtimeTemplatesHandler class with all the methods to entertain templates realtime logic. - cleaned the RealtimeTemplates HOC to only points to relevant methods in the RealtimeTempaltesHandler class.
- created a separate service file name public.service for tasks - created a separate abstract service which inherits base service and extended by PublicTasksService and TasksService. This file contains all the utilities shared by both of the services. - changed methods in public.controller for tasks - refactored tasks service
…rom both services using the template pattern
…pe of utility methods
SandipBajracharya
force-pushed
the
feature/api-improvements
branch
from
a7df534 to
cdd4a58
Compare
- All the comments endpoint, list comments, retrieve comments and deleted comments paths have been changed not requiring task/{taskId} anymore.
- The new comments public url goes something like : {{url}}/api/comment/public?token for list and {{url}}/api/comment/public/{{id}}?token for retrieve and delete.
- Added a security mechasim of checking task access scope directly in comments.findMany() filters instead of traversing comments.
…comment to api/comments
…comment to api/comments
…on public API response. Removed images tags, attachment tags and empty paragraph tags
- Added a sanitize fileName function which strips off any uuids in the beginning of a file. - The above method is not very ideal because an original fileName could contain a UUID but this a the case im considering right now. - To prevent any of this in the future, create an extra flow to store originalFileName in the metadata of the uploaded file. While creating an attachment entry from that file, used the originalFileName metadata property to extract a clean file name.
…lder comments which had the property as null
…s and cus on array on backfill initiator type script for comments
…into feature/api-improvements
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes