merge api-improvements feature to staging #1118
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- created a mechanism to support creating entries on attachments tables based on files/images uploaded on - task creation - task description update - subtask creation - subtask description update - comment/reply creation - comment/reply update - Entries on attachments table are done from api services when task/comments are created and from fronend client components when tasks/comments are edited. - Remaining: Clean deleted attachments from attachments table while clearing out scrap medias
- added a mechanism to extract attachments when comment/reply is created, move them to their respective folder and create an entry on attachments table. - Cleaning deleted attachments from attachments table while clearing out scrap medias.
…on issues. totally segregated replies/comments to have their own attachment entities
…on issues. totally segregated replies/comments to have their own attachment entities
…achment. workspaceId is needed for building folder structure effecting filePaths
- [x] public api route that gets list of comments for a task - [x] taskId required validation - [x] accept params: taskId, parentCommentId, createdBy - [x] include attachment in reponse with presigned download url
… supabase storage at once
- [x] accept comment id as path variable - [x] include attachments in response - [x] serialize response data
- [x] public api route that gets list of comments for a task - [x] taskId required validation - [x] accept params: taskId, parentCommentId, createdBy - [x] include attachment in reponse with presigned download url
- [x] accept comment id as path variable - [x] delete comment along with attachments associated to it - [x] code refactor by implementing transaction in existing delete function
- [x] check comment task permission. User with permission to access task should have access to its comments - [x] refactor: function name change
- [x] accept comment id as path variable - [x] delete comment along with attachments associated to it - [x] code refactor by implementing transaction in existing delete function
- [x] directly delete comment attachments from bucket when the comment is deleted - [x] refactor: create separate function that handles attachment deletion
- [x] create dispatchable event commend is created - [x] create a function that returns the comment attachments
- [x] include non deleted attributes in response for list, get one, create, update
- All the comments endpoint, list comments, retrieve comments and deleted comments paths have been changed not requiring task/{taskId} anymore.
- The new comments public url goes something like : {{url}}/api/comment/public?token for list and {{url}}/api/comment/public/{{id}}?token for retrieve and delete.
- Added a security mechasim of checking task access scope directly in comments.findMany() filters instead of traversing comments.
…comment to api/comments
…comment to api/comments
…on public API response. Removed images tags, attachment tags and empty paragraph tags
- Added a sanitize fileName function which strips off any uuids in the beginning of a file. - The above method is not very ideal because an original fileName could contain a UUID but this a the case im considering right now. - To prevent any of this in the future, create an extra flow to store originalFileName in the metadata of the uploaded file. While creating an attachment entry from that file, used the originalFileName metadata property to extract a clean file name.
…lder comments which had the property as null
…s and cus on array on backfill initiator type script for comments
chore(out-2927) revert back to node 20
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.