Skip to content

OUT-2775 | Disconnect sync button is not working #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rrojan merged 2 commits into from
Dec 9, 2025
Merged

OUT-2775 | Disconnect sync button is not working #39

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
077a170
fix(OUT-2775): force react to store a fresh copy of app bridge callbacks
rrojan Dec 9, 2025
b525dcb
fix(OUT-2775): see if callback solves this issue
rrojan Dec 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions src/features/settings/hooks/useAppMenu.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,39 +3,32 @@
import { useAuthContext } from '@auth/hooks/useAuth'
import { disconnectApp } from '@settings/actions/disconnectApp'
import { useSettingsContext } from '@settings/hooks/useSettings'
import { useState } from 'react'
import { useCallback } from 'react'
import { useActionsMenu } from '@/lib/copilot/hooks/app-bridge'
import { Icons } from '@/lib/copilot/hooks/app-bridge/types'

export const useAppBridge = ({ token }: { token: string }) => {
const { connectionStatus } = useAuthContext()
const { isSyncEnabled, updateSettings, initialSettings } = useSettingsContext()

const disconnectAppAction = async () => {
const disconnectAppAction = useCallback(async () => {
await disconnectApp(token)
updateSettings({
isSyncEnabled: false,
initialSettings: { ...initialSettings, isSyncEnabled: false },
})
}
}, [token, updateSettings, initialSettings])

// biome-ignore lint/suspicious/useAwait: there is no async action being done here but the type signature requires it
const _downloadCsvAction = async () => {
const downloadCsvAction = useCallback(async () => {
const url = `/api/sync-logs?token=${token}`
const link = document.createElement('a')
link.href = url
link.download = 'sync-history.csv'
document.body.appendChild(link)
link.click()
link.remove()
}

// Quickfix for now (it will probably stay like this for the end of time)
const [downloadCsvAction, setDownloadCsvAction] = useState(() => _downloadCsvAction)

setTimeout(() => {
setDownloadCsvAction(() => _downloadCsvAction)
}, 1000)
}, [token])

let actions: { label: string; icon?: Icons; onClick: () => Promise<void> }[] = []
if (connectionStatus) {
Expand Down