Skip to content

OUT-2661 | Marking an invoice as paid in assembly does not update in Xero #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rrojan merged 1 commit into from
Dec 12, 2025
Merged

OUT-2661 | Marking an invoice as paid in assembly does not update in Xero #40

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/features/invoice-sync/lib/SyncedAccounts.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ class SyncedAccountsService extends AuthenticatedXeroService {
'SyncedAccountsService#getOrCreateCopilotSalesAccount :: Getting copilot sales account',
)

const accounts = await this.xero.getAccounts(this.connection.tenantId, 'REVENUE')
const accounts = await this.xero.getAccounts(this.connection.tenantId)
let salesAccount = accounts.find((acc) => acc.code === AccountCode.SALES)

// CASE I: Sales account exists
Expand Down Expand Up @@ -54,7 +54,7 @@ class SyncedAccountsService extends AuthenticatedXeroService {
'SyncedAccountsService#getOrCreateCopilotExpenseAccount :: Getting copilot expense account',
)

const accounts = await this.xero.getAccounts(this.connection.tenantId, 'EXPENSE')
const accounts = await this.xero.getAccounts(this.connection.tenantId)
let expenseAccount = accounts.find((acc) => acc.code === AccountCode.MERCHANT_FEES)

// CASE I: Expense account exists
Expand Down
2 changes: 1 addition & 1 deletion src/lib/xero/XeroAPI.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,7 @@ class XeroAPI {
const { body } = await this.xero.accountingApi.createAccount(tenantId, {
name: SALES_ACCOUNT_NAME,
code: AccountCode.SALES,
type: AccountType.REVENUE,
type: AccountType.SALES,
description: 'Revenue from selling goods or products.',
enablePaymentsToAccount: true,
})
Expand Down