OUT-2801 | OUT-2802: handle edge case for workspace with no products #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- [x] early return null value if no products or prices are found - [x] add optional chaining and ternary operations wherever necessary
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
arpandhakal
approved these changes
Dec 23, 2025
rrojan
reviewed
Dec 24, 2025
Comment on lines
+171
to
+172
|
|
||
| if (!allPricesResponse.data) return null |
Collaborator
There was a problem hiding this comment.
We are returning a hashmap of priceId in key, price in value - we should keep our typing semantic and return {} instead if there are no prices.
That way we only have to change 1 line in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Testing Criteria
If no products in workspace, then gives
Create Productoption