fix #257 to infer as object when only required array set #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
thank you for working on this ! could you add a changeset so I can merge it ? |
marrowleaves
force-pushed
the
fix/257-required-props
branch
from
e415a83 to
dfe4dcf
Compare
Sure, changeset text generated |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #257
Now
getZodSchemawould treat schema object withrequireddefined as an array of typeobjectand correctly infer the type.The fix also checks extra properties in
requiredarray but not defined inproperties, inferred as additional props.The fix doesn't handle the case when
additionalPropertiesare defined and mixed withrequiredarray. It seems that the current implementation doesn't handle the mix ofadditionalPropertiesandpropertieseither. But it would be easy to append theextraPropertiesstring generated fromrequiredto the code string generated foradditionalProperties, after it's properly handled.