Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(sequencer): add instrumentation #1761

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ethanoroshiba
Copy link
Contributor

Summary

Added instrumentation to most async functions which did not have it.

Background

Adding instrumentation to all async calls will aid in tracing since spans will be emitted even if no events happen under them.

Changes

  • Added instrumentation to most async functions which did not have it.
  • Added err argument to the instrument macro where applicable.
  • Added fields to the instrument macro where applicable.

Testing

Passing all tests.

Changelogs

No updates required

Related Issues

closes #1321

@github-actions github-actions bot added the sequencer pertaining to the astria-sequencer crate label Oct 28, 2024
@ethanoroshiba ethanoroshiba marked this pull request as ready for review October 29, 2024 13:22
@ethanoroshiba ethanoroshiba requested a review from a team as a code owner October 29, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code-quality sequencer pertaining to the astria-sequencer crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

chore: add instrumentation on all async calls
1 participant