chore(sequencer): index all ABCI events

[ethanoroshiba]

Summary

Instructs CometBFT to index all ABCI events emitted by Sequencer.

Background

This change instructs CometBFT to index all events emitted by Sequencer by setting their field index: true.

This allows programatically determining stuck IBC transactions to automatically trigger a timeout. Previously, the height that a given IBC packet was sent at had to be found manually before it could be passed to the Hermes CLI (Astria's IBC relayer of choice).

The indexing field is described in the CometBFT ABCI spec [1].

1: https://github.com/cometbft/cometbft/blob/16b1ed87c4b10118df10eb7175412db066bd09d5/spec/abci/abci%2B%2B_basic_concepts.md?plain=1#L318-L319

Changes

• Index all event attributes before returning in app::execute_transaction

Testing

• Added unit test to ensure all event attributes are indexed for the events we create (unable to unit test an IBC action).

Changelogs

Changelog updated

[noot]

the title and changelog should be updated to say all events are now indexed, not just send_packet ones. otherwise looks good!

[SuperFluffy]

Couple notes:

1. If abci events are toggled on every execution, then this should be in execute_transactions and the code not duplicated in every fn execute_transactions_* method.
2. Please expand the background section, right now it contains a placeholder.
3. These changes are observable by providing a unit test on execute_transactions. The test section right now is equivalent to saying "this is not tested".
4. This should further be observable by spinning up a sequencer network and checking the provided ABCI events.

[SuperFluffy]

I have updated the patch title and description a bit (arguably, this is more chore-like or feat-like than a fix for sequencer proper).

I have also linked the relevant entry in the cometbft repository (preferable over a website that is more likely to change).

Please address @Fraser999's comment re the unnecessary filter adapter when enabled all indexing.