-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iterative refinement support for JAX and NumPy forward (spherical) transform implementations #241
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #241 +/- ##
==========================================
+ Coverage 96.07% 96.11% +0.04%
==========================================
Files 31 31
Lines 3567 3581 +14
==========================================
+ Hits 3427 3442 +15
+ Misses 140 139 -1 ☔ View full report in Codecov by Sentry. |
@matt-graham looks great, one thing that would also be good to add is the same iterations but for the precompute versions of the transforms. |
Good point @CosmoMatt (re precompute). We could either do that in the current PR if quick or else do it in a next one. |
@CosmoMatt - just to check by precompute versions, do you mean the Also, with regards to the |
Should resolve #139
Adds support for using
iter
keyword argument tos2fft.forward
when usingmethod = "numpy"
andmethod = "jax"
, using an iterative refinement approach equivalent to that implemented inhealpy
to improve accuracy of forward transform (in terms of acting as the inverse of the inverse transform).Currently this is only added for spherical transform, and is available for all sampling types, even though in practice probably only useful for HEALPix (though
iter=1
does seem to give a small gain in accuracy for other sampling types).